MWPW-157887 [MEP] HTML elements like body need to be recognized and header simplified selector rename #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2843 +/- ##
==========================================
+ Coverage 95.87% 96.08% +0.20%
==========================================
Files 173 215 +42
Lines 46333 53947 +7614
==========================================
+ Hits 44421 51833 +7412
- Misses 1912 2114 +202 ☔ View full report in Codecov by Sentry. |
denlight
approved these changes
Sep 5, 2024
ivanvatadobe
approved these changes
Sep 5, 2024
|
Reminder to set the |
AdobeLinhart
approved these changes
Sep 6, 2024
…but not in Target (#2844) Fix preview bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Description: selectors involving html elements like body break because MEP is not aware of them.
Changing "header" simplified selector to "any-header" since pages always have a header tag.
................................
URL: https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepmorehtmlels/?mepHighlight=true
................................
Steps to Reproduce:
Expected Results: should be 2 items highlighted, the new marquee header and a div below the marquee
................................
Actual Results: no highlighted items because nothing is added
Resolves: MWPW-157887
Test URLs:
Before: https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepmorehtmlels/?mepHighlight=true&martech=off
After: https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepmorehtmlels/?milolibs=mepmorehtmlels&mepHighlight=true&martech=off
Psi-check: https://mepmorehtmlels--milo--adobecom.hlx.page/?martech=off
Also includes this approved PR to avoid conflicts: #2844