generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-157686 [MEP] Cannot spoof an experience that exists in manifest but not in Target #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mepmorehtmlels #2844 +/- ##
=================================================
Coverage ? 96.08%
=================================================
Files ? 215
Lines ? 53944
Branches ? 0
=================================================
Hits ? 51833
Misses ? 2111
Partials ? 0 ☔ View full report in Codecov by Sentry. |
vgoodric
approved these changes
Sep 5, 2024
AdobeLinhart
approved these changes
Sep 6, 2024
narcis-radu
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a pzn manifest with some Target columns and some non Target columns, it is often placed in the pzn metadata AND in Target. If a column is added to the manifest but Target is not updated, then you see the new experience in the MEP button, but you cannot spoof it with the manifest.
QA instructions: go to the before and after links below and expand the MEP button. "mobile-device" is correctly selected only in the after link
Resolves: MWPW-157686
Test URLs: