Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157686 [MEP] Cannot spoof an experience that exists in manifest but not in Target #2844

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

markpadbe
Copy link
Contributor

@markpadbe markpadbe commented Sep 5, 2024

When you have a pzn manifest with some Target columns and some non Target columns, it is often placed in the pzn metadata AND in Target. If a column is added to the manifest but Target is not updated, then you see the new experience in the MEP button, but you cannot spoof it with the manifest.

QA instructions: go to the before and after links below and expand the MEP button. "mobile-device" is correctly selected only in the after link

Resolves: MWPW-157686

Test URLs:

@markpadbe markpadbe requested a review from a team as a code owner September 5, 2024 21:33
Copy link
Contributor

aem-code-sync bot commented Sep 5, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@markpadbe markpadbe requested a review from a team September 5, 2024 21:33
Copy link
Contributor

aem-code-sync bot commented Sep 5, 2024

Page Scores Audits Google
M /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (mepmorehtmlels@510f7a6). Learn more about missing BASE report.
Report is 2 commits behind head on mepmorehtmlels.

Additional details and impacted files
@@                Coverage Diff                @@
##             mepmorehtmlels    #2844   +/-   ##
=================================================
  Coverage                  ?   96.08%           
=================================================
  Files                     ?      215           
  Lines                     ?    53944           
  Branches                  ?        0           
=================================================
  Hits                      ?    51833           
  Misses                    ?     2111           
  Partials                  ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgoodric vgoodric requested a review from a team September 5, 2024 22:26
@vgoodric vgoodric changed the base branch from stage to mepmorehtmlels September 6, 2024 19:49
@vgoodric vgoodric merged commit e21c441 into mepmorehtmlels Sep 6, 2024
13 checks passed
@vgoodric vgoodric deleted the spoofpznexperience branch September 6, 2024 19:49
milo-pr-merge bot pushed a commit that referenced this pull request Sep 9, 2024
…eader simplified selector rename (#2843)

* add more html els and change header to any header

* MWPW-157686 [MEP] Cannot spoof an experience that exists in manifest but not in Target (#2844)

Fix preview bug

---------

Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com>
elan-tbx pushed a commit that referenced this pull request Sep 9, 2024
…eader simplified selector rename (#2843)

* add more html els and change header to any header

* MWPW-157686 [MEP] Cannot spoof an experience that exists in manifest but not in Target (#2844)

Fix preview bug

---------

Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com>
mokimo pushed a commit that referenced this pull request Sep 11, 2024
yesil pushed a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants