Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-160958][NALA] Increase Nala test execution worker count in GitHub #3086

Merged
merged 65 commits into from
Oct 24, 2024

Conversation

skumar09
Copy link
Contributor

  • Increase Nala tests parallel execution on GitHub
  • Include Nala tests execution on the WebKit browser

Resolves: MWPW-160958

Test URLs:

milo-pr-merge bot and others added 10 commits October 1, 2024 08:04
adobecom#3014)

[MWPW-159328] handle a case where there are not placeholders available (adobecom#2998)

* [MWPW-159328] handle a case where there are not palceholders availble

* fixed typos

---------

Co-authored-by: Denys Fedotov <denlight@gmail.com>
Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
…adobecom#3023)

* stash

* stash

* stash

* working well

* set updated command list for inline

* remove querySelector function

* unit test and custom block fix

* updates for in-block

* merch-card-collection unit test fixed

* unit test updates

* more unit test repair

* linting errors

* more linting

* Fix Invalid selector test

* add coverage

* force git checks to refire

* remove comment

* pass rootEl to getSelectedElements for use when needed (gnav)

* skip if clause in codecov

---------

Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: markpadbe <markp@adobe.com>
…becom#2991)

* Revert "MWPW-156749: Fix video CLS " (adobecom#2899) (adobecom#2900)

Revert "MWPW-156749: Fix video CLS  (adobecom#2849)"

This reverts commit d4134c8.

* Changing z-index of promobar and popup

* Changing z-index of promobar and popup

* Reverting z-index to 4 for promobar

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Akansha Arora <>
Copy link
Contributor

aem-code-sync bot commented Oct 23, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (332c3a5) to head (496cacf).
Report is 21 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3086      +/-   ##
==========================================
+ Coverage   96.40%   96.44%   +0.03%     
==========================================
  Files         243      245       +2     
  Lines       55415    55746     +331     
==========================================
+ Hits        53425    53762     +337     
+ Misses       1990     1984       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skumar09 skumar09 changed the title [MWPW-160958][NALA] Increase Nala tests parallel execution on GitHub [MWPW-160958][NALA] Increase Nala test execution worker count in GitHub Oct 23, 2024
Copy link
Contributor

@amauch-adobe amauch-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mokimo mokimo merged commit 2392240 into adobecom:stage Oct 24, 2024
18 checks passed
@mokimo mokimo mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants