[MWPW-161236][NALA] Nala Accessibility Test Bot (A11y Bot) #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix quiz marquees
adobecom#3014) [MWPW-159328] handle a case where there are not placeholders available (adobecom#2998) * [MWPW-159328] handle a case where there are not palceholders availble * fixed typos --------- Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
…adobecom#3023) * stash * stash * stash * working well * set updated command list for inline * remove querySelector function * unit test and custom block fix * updates for in-block * merch-card-collection unit test fixed * unit test updates * more unit test repair * linting errors * more linting * Fix Invalid selector test * add coverage * force git checks to refire * remove comment * pass rootEl to getSelectedElements for use when needed (gnav) * skip if clause in codecov --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com>
…becom#2991) * Revert "MWPW-156749: Fix video CLS " (adobecom#2899) (adobecom#2900) Revert "MWPW-156749: Fix video CLS (adobecom#2849)" This reverts commit d4134c8. * Changing z-index of promobar and popup * Changing z-index of promobar and popup * Reverting z-index to 4 for promobar --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Akansha Arora <>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3109 +/- ##
==========================================
- Coverage 96.43% 96.33% -0.10%
==========================================
Files 245 247 +2
Lines 55746 56235 +489
==========================================
+ Hits 53757 54176 +419
- Misses 1989 2059 +70 ☔ View full report in Codecov by Sentry. |
skumar09
requested review from
mokimo,
narcis-radu,
overmyheadandbody,
amauch-adobe,
JackySun9,
sigadamvenkata and
robert-bogos
JackySun9
approved these changes
Oct 29, 2024
sigadamvenkata
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessibility Testing Bot that efficiently automates accessibility tests via simple commands in a VS Code terminal. This bot would enable comprehensive WCAG compliance checks across URLs and easy report generation.
Acceptance Criteria:
- Command:
npm run a11y [options]- Description: Run the accessibility testing command directly from the VS Code terminal, simplifying the workflow for local testing.
- Command:
npm run a11y <url>- Description: Run accessibility tests on the specified URL, quickly assessing the target page’s compliance with
accessibility standards.
- Command:
npm run a11y <url> --tags=<wcag_tags>- Description: Execute accessibility testing on a URL, specifying WCAG tags (e.g., wcag2a, wcag2aa, wcag21a) for targeted compliance testing.
- Tags Parameter: Accept comma-separated WCAG tags to filter specific accessibility criteria, allowing customized testing.
- Command:
npm run a11y --file=<file_path>- Description: Perform accessibility testing on multiple URLs listed in a specified file, enabling batch testing for
various pages.
- File Format: Support
.txt format,where each line contains one URL.- Output: Automatically generate an HTML report summarizing accessibility violations, WCAG tags tested, and
overall compliance status for each URL.
- Report Features: Include metadata (test date, URL, tester), organized listing of violations, severity level, and
recommendations.
- HTML Report File Naming: For easy tracking, use a timestamped filename format (e.g., a11y_report_.html).
Resolves: MWPW-161236
Test URLs:
Test / Results
npm run a11y urlnpm run a11y url( has violation)npm run a11y url -- -t wcag2a,wcag2aa( with wcag tags)npm run a11y -- -f 'filename.txt'