MWPW-159032: Accessibility requirements floating label #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
joaquinrivero
requested review from
nkthakur48,
chrischrischris and
auniverseaway
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3137 +/- ##
==========================================
- Coverage 96.35% 96.35% -0.01%
==========================================
Files 245 245
Lines 56316 56314 -2
==========================================
- Hits 54261 54259 -2
Misses 2055 2055 ☔ View full report in Codecov by Sentry. |
tedAir
approved these changes
Nov 5, 2024
tedAir
added
Ready for Stage
verified
|
Skipped merging 3137: MWPW-159032: Accessibility requirements floating label due to insufficient approvals. Required: 2 approvals |
TsayAdobe
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-159032
Test URLs:
Before: https://main--dc--adobecom.hlx.page/drafts/rivero/ratings&martech=off
After: https://mwpw-159032-ratings--milo--joaquinrivero.hlx.page/drafts/rivero/ratings&martech=off