[Release] Stage to Main #3160

milo-pr-merge · 2024-11-07T18:45:25Z

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

* style wrappers when no nested elements * better logic and check for text nodes in elements * dialing in util * keep contains text function in decorate js * use is magic in emtpy elements selector * simplify el contains text function * early return in block text decorator * codecov on decorate block text * adjust decorate and marquee anchors to hopefully pass tests * style wrappers when no nested elements * better logic and check for text nodes in elements * dialing in util * keep contains text function in decorate js * use is magic in emtpy elements selector * simplify el contains text function * early return in block text decorator * codecov on decorate block text * adjust decorate and marquee anchors to hopefully pass tests * fix marquee anchors for nala

…ection (#3101) * make mini-compare footer rows unordered list for accessiblity * dummy commit * Revert "dummy commit" This reverts commit a3a8824. --------- Co-authored-by: Rohit Sahu <rosahu@adobe.com>

* links conversion localization support * added unit tests

Adds a floating label as accessibility requirements for comments field

* feat: support full height media * feat: support full height media fix: no border for media card * add test * remove redundant pseudo-code

milo-pr-merge · 2024-11-07T18:45:26Z

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

aem-code-sync · 2024-11-07T18:45:30Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

df454db ✅ (latest)
f379815 ✅
35a3102 ✅
a7f61d1 ✅
819e6f3 ✅
8b372b4 ✅
948a940 ✅
fe3acdb ✅
36e869f ✅

aem-code-sync · 2024-11-07T18:45:49Z

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

github-actions · 2024-11-07T18:48:37Z

libs/deps/mas/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-07T18:48:38Z

libs/deps/mas/merch-card.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-07T18:48:39Z

libs/features/mas/mas/dist/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-07T18:48:40Z

libs/features/mas/web-components/src/variants/mini-compare-chart.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

codecov · 2024-11-07T18:48:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (f950ca5) to head (df454db).
Report is 81 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3160      +/-   ##
==========================================
+ Coverage   96.35%   96.38%   +0.02%     
==========================================
  Files         245      245              
  Lines       56420    56651     +231     
==========================================
+ Hits        54362    54601     +239     
+ Misses       2058     2050       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* MWPW-157987: Missing tests and card id copy message * MWPW-157987: add missing import * MWPW-157987: Removed comment

…idual SVG assets (#2986) * updated features/icons to pull from federal and allow the icons set to be sharepoint authorable * bettter icon-spacing handling * preload federated.js instead of non used icons.svg on util decorateIcon() * Updated preload federated as script type not fetch * Minor clean up based on pr feedback * remove console * addressed some issues found w/ icons not rending in tables due to race condition w/ decorateIcon() * lana instead of console * no 100% height * coverage * full coverage * minor cleanup * minor cleanup * preload first section icons, spread syntax * no cons * Performace refactor - loadIcons to hold most related functionallity. Preloaded inView icons and defered others till postSectionLoad. * async decTooltips and refactor to not chain func calls * fix: icon alignment in georouting modal's button * move render blocking code to utils * fix import of test method * remove condition that causes error when no icon is in view * remove redundant link load * remove extra federated.js import --------- Co-authored-by: Saugat Malla <saugat@TBXTOR-2021MBP16-SaugatMalla.local> Co-authored-by: Saugat Malla <saugat013@gmail.com>

* MWPW-159374: Update hydrate logic to support all cta styles organise code and code coverage Update tests * add workaround for ccd-suggested cards * remove source maps * improve code coverage * cleanup all attributes during card hydration

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/df454db2a05b123873bf70842505aad575f1446c/libs/features/mas/web-components/src/variants/ccd-suggested.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/df454db2a05b123873bf70842505aad575f1446c/libs/features/mas/web-components/src/variants/special-offer.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/df454db2a05b123873bf70842505aad575f1446c/libs/features/mas/web-components/test/hydrate.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/df454db2a05b123873bf70842505aad575f1446c/libs/features/mas/web-components/test/mas.js

github-actions · 2024-11-08T10:33:08Z

libs/deps/mas/commerce.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Roycethan

@mokimo / @overmyheadandbody cc @seanchoi-dev I see changed adobe brand logo on stage https://www.stage.adobe.com/ - is it intentional? can you plz review ?

Roycethan · 2024-11-11T19:21:06Z

@mokimo / @overmyheadandbody cc @seanchoi-dev I see changed adobe brand logo on stage https://www.stage.adobe.com/ - is it intentional? can you plz review ?

Looks like intentional per project Red, although the error on old logo request should be handled, approving for now

Sartxi and others added 6 commits November 7, 2024 18:44

[MWPW-154662] [Accessibility] Visual list is not marked up as list: s…

fe3acdb

…ection (#3101) * make mini-compare footer rows unordered list for accessiblity * dummy commit * Revert "dummy commit" This reverts commit a3a8824. --------- Co-authored-by: Rohit Sahu <rosahu@adobe.com>

[MWPW-161098] Links conversion localization support (#3120)

948a940

* links conversion localization support * added unit tests

MWPW-160966 Fix next-gen sidekick preflight (#3126)

8b372b4

MWPW-159032: Accessibility requirements floating label (#3137)

819e6f3

Adds a floating label as accessibility requirements for comments field

[MWPW-160719] - Support media only in Editorial-Card (#3144)

a7f61d1

* feat: support full height media * feat: support full height media fix: no border for media card * add test * remove redundant pseudo-code

milo-pr-merge bot requested review from nkthakur48, chrischrischris, auniverseaway and a team as code owners November 7, 2024 18:45

github-actions bot reviewed Nov 7, 2024

View reviewed changes

mokimo temporarily deployed to milo_pr_merge November 7, 2024 20:11 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 8, 2024 00:49 — with GitHub Actions Inactive

MWPW-157987: Missing tests and card id copy message (#3024)

35a3102

* MWPW-157987: Missing tests and card id copy message * MWPW-157987: add missing import * MWPW-157987: Removed comment

aem-code-sync bot temporarily deployed to stage November 8, 2024 00:49 Inactive

mokimo temporarily deployed to milo_pr_merge November 8, 2024 04:12 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 8, 2024 08:13 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 8, 2024 09:15 — with GitHub Actions Inactive

overmyheadandbody requested a review from ryanmparrish as a code owner November 8, 2024 10:12

github-actions bot reviewed Nov 8, 2024

View reviewed changes

mokimo temporarily deployed to milo_pr_merge November 11, 2024 08:14 — with GitHub Actions Inactive

sigadamvenkata approved these changes Nov 11, 2024

View reviewed changes

sigadamvenkata added the CC SOT 👌 label Nov 11, 2024

sigadamvenkata temporarily deployed to milo_pr_merge November 11, 2024 09:04 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 11, 2024 09:16 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 11, 2024 12:19 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 11, 2024 16:12 — with GitHub Actions Inactive

Roycethan requested changes Nov 11, 2024

View reviewed changes

Roycethan added the Homepage SOT 👌 label Nov 11, 2024

Roycethan temporarily deployed to milo_pr_merge November 11, 2024 18:42 — with GitHub Actions Inactive

tedAir self-requested a review November 11, 2024 19:06

tedAir approved these changes Nov 11, 2024

View reviewed changes

tedAir added the DC SOT 👌 label Nov 11, 2024

tedAir temporarily deployed to milo_pr_merge November 11, 2024 19:07 — with GitHub Actions Inactive

JackySun9 approved these changes Nov 11, 2024

View reviewed changes

JackySun9 added BAcom SOT 👌 MIQ SOT👌 labels Nov 11, 2024

JackySun9 temporarily deployed to milo_pr_merge November 11, 2024 19:19 — with GitHub Actions Inactive

Roycethan self-requested a review November 11, 2024 19:21

Roycethan approved these changes Nov 11, 2024

View reviewed changes

mokimo temporarily deployed to milo_pr_merge November 11, 2024 20:11 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 12, 2024 00:49 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 12, 2024 04:12 — with GitHub Actions Inactive

aem-code-sync bot temporarily deployed to mepskipload2 November 12, 2024 07:27 Inactive

mokimo temporarily deployed to milo_pr_merge November 12, 2024 08:13 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge November 12, 2024 09:15 — with GitHub Actions Inactive

milo-pr-merge bot merged commit 82c26e1 into main Nov 12, 2024
86 of 87 checks passed

milo-pr-merge bot temporarily deployed to milo_pr_merge November 12, 2024 09:15 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Release] Stage to Main #3160

[Release] Stage to Main #3160

milo-pr-merge bot commented Nov 7, 2024 •

edited by overmyheadandbody

Loading

milo-pr-merge bot commented Nov 7, 2024

aem-code-sync bot commented Nov 7, 2024 •

edited

Loading

aem-code-sync bot commented Nov 7, 2024 •

edited

Loading

github-actions bot Nov 7, 2024

github-actions bot Nov 7, 2024

github-actions bot Nov 7, 2024

github-actions bot Nov 7, 2024

codecov bot commented Nov 7, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot Nov 8, 2024

Roycethan left a comment •

edited

Loading

Roycethan commented Nov 11, 2024 •

edited

Loading

[Release] Stage to Main #3160

[Release] Stage to Main #3160

Conversation

milo-pr-merge bot commented Nov 7, 2024 • edited by overmyheadandbody Loading

common base root URLs

milo-pr-merge bot commented Nov 7, 2024

aem-code-sync bot commented Nov 7, 2024 • edited Loading

aem-code-sync bot commented Nov 7, 2024 • edited Loading

github-actions bot Nov 7, 2024

Choose a reason for hiding this comment

github-actions bot Nov 7, 2024

Choose a reason for hiding this comment

github-actions bot Nov 7, 2024

Choose a reason for hiding this comment

github-actions bot Nov 7, 2024

Choose a reason for hiding this comment

codecov bot commented Nov 7, 2024 • edited Loading

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 8, 2024

Choose a reason for hiding this comment

Roycethan left a comment • edited Loading

Choose a reason for hiding this comment

Roycethan commented Nov 11, 2024 • edited Loading

milo-pr-merge bot commented Nov 7, 2024 •

edited by overmyheadandbody

Loading

aem-code-sync bot commented Nov 7, 2024 •

edited

Loading

aem-code-sync bot commented Nov 7, 2024 •

edited

Loading

codecov bot commented Nov 7, 2024 •

edited

Loading

Roycethan left a comment •

edited

Loading

Roycethan commented Nov 11, 2024 •

edited

Loading