-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-160360 - Decorate standalone text with body default styles #3060
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3060 +/- ##
==========================================
- Coverage 96.35% 96.35% -0.01%
==========================================
Files 245 245
Lines 56365 56424 +59
==========================================
+ Hits 54311 54367 +56
- Misses 2054 2057 +3 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
…MWPW-160360-text
Skipped merging 3060: MWPW-160360 - Decorate standalone text with body default styles due to failing checks |
3 similar comments
Skipped merging 3060: MWPW-160360 - Decorate standalone text with body default styles due to failing checks |
Skipped merging 3060: MWPW-160360 - Decorate standalone text with body default styles due to failing checks |
Skipped merging 3060: MWPW-160360 - Decorate standalone text with body default styles due to failing checks |
…MWPW-160360-text
…MWPW-160360-text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still try to find the reason why the Nala tests are failing 🤔
Skipped merging 3060: MWPW-160360 - Decorate standalone text with body default styles due to failing checks |
8e62a11
to
2cbb145
Compare
…/milo into sartxi/MWPW-160360-text
When standalone content is not decorated according to its format or a text style override, the decorate text function will add default body styling like it does with other empty elements.
This will apply default styles to text in consonant blocks that use the shared text decorate functionality.
Resolves: MWPW-160360
Test URLs:
Before: https://main--milo--adobecom.hlx.page/drafts/sarchibeque/format-text?martech=off
After: https://sartxi-mwpw-160360-text--milo--adobecom.hlx.page/drafts/sarchibeque/format-text?martech=off
Before: https://main--milo--adobecom.hlx.page/drafts/sarchibeque/standalone-text?martech=off
After: https://sartxi-mwpw-160360-text--milo--adobecom.hlx.page/drafts/sarchibeque/standalone-text?martech=off