[MWPW-160719] - Support media only in Editorial-Card #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: no border for media card
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3144 +/- ##
=======================================
Coverage 96.34% 96.35%
=======================================
Files 245 245
Lines 56312 56380 +68
=======================================
+ Hits 54252 54323 +71
+ Misses 2060 2057 -3 ☔ View full report in Codecov by Sentry. |
rgclayton
approved these changes
Nov 6, 2024
overmyheadandbody
approved these changes
Nov 6, 2024
robert-bogos
approved these changes
Nov 6, 2024
Comment on lines
+47
to
+48
| const editorialCardWithMediaOnly = editorialCards[8]; | ||
| expect(editorialCardWithMediaOnly.classList.contains('no-foreground')).to.be.true; |
There was a problem hiding this comment.
Nit: no need to cache in here
Suggested change
| const editorialCardWithMediaOnly = editorialCards[8]; | |
| expect(editorialCardWithMediaOnly.classList.contains('no-foreground')).to.be.true; | |
| expect(editorialCards[8].classList.contains('no-foreground')).to.be.true; |
|
Reminder to set the |
SilviuLCF
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Verified, testing details https://jira.corp.adobe.com/browse/MWPW-160719
Sartxi
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support to have only media in Editorial card. When there is no copy content in the editorial-card, the media will fill the container.
Resolves: MWPW-160719
Test URLs: