-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-162847 [MEP][nala] add ul-li selector test #3238
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3238 +/- ##
=======================================
Coverage 96.37% 96.38%
=======================================
Files 245 245
Lines 56716 56716
=======================================
+ Hits 54661 54663 +2
+ Misses 2055 2053 -2 ☔ View full report in Codecov by Sentry. |
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
This tests the ul and li selectors (and skips ol because we don't have anything in the library that uses ol in the plain html)
Resolves: MWPW-162847
Test URLs:
tests li selectors: https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/ul-ol-li/li-selectors
tests ul selector: https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/ul-ol-li/ul-selector
compare with their default pages:
https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/ul-ol-li/ul-selector?mep=%2Fdrafts%2Fnala%2Ffeatures%2Fpersonalization%2Ful-ol-li%2Ful-selector.json--default
https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/ul-ol-li/li-selectors?mep=%2Fdrafts%2Fnala%2Ffeatures%2Fpersonalization%2Ful-ol-li%2Fli-selectors.json--default