Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #3315

Merged
merged 13 commits into from
Dec 9, 2024
Merged

[Release] Stage to Main #3315

merged 13 commits into from
Dec 9, 2024

Conversation

milo-pr-merge[bot]
Copy link
Contributor

@milo-pr-merge milo-pr-merge bot commented Dec 5, 2024 •
edited by mokimo
Loading

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

jpratt2 and others added 6 commits December 5, 2024 17:23
@jpratt2
MWPW-162847 [MEP][nala] add ul-li selector test (#3238)
44ee6f1 
* add ul-li selector test

* add test id

---------

Co-authored-by: John Pratt <jpratt@adobe.com>
@skumar09
[MWPW-162711][NALA] Update Table block tests to validate tooltip info…
11b61cc 
…rmation (#3267)

update table tests with tooltip

Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@santoshumarsmbp.corp.adobe.com>
@swamu
fix no cookie preference in stage (#3309)
ff58d7e
@robert-bogos
[MWPW-161570] Ensure hardcoded decorative SVGs have aria-hidden="true" (
023541d 
#3247)

* inline svgs skipped by screen readers

* addressed feedback

* addressed feedback

* addressed feedback

* removed role attribute from decorative svgs

* hotfix

* hotfix
@overmyheadandbody
Allow setting of aria label text for links (#3255)
7cc4058 
* [MWPW-157500] Aria label first demo

* [MWPW-157500] Aria label allow icons for pipe oprion

* [MWPW-161396] Remove obsolete solutions; streamline; add UTs

* [MWPW-161396] Adapt NALA test

* [MWPW-161396] Update aria label UT
@bandana147
Picking first string only for localnav title (#3281)
82098c7 
* Picking first string only for localnav title

* Lint fix
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Dec 5, 2024

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Dec 5, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Dec 5, 2024 •
edited
Loading

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

github-actions[bot]
github-actions bot reviewed Dec 5, 2024
View reviewed changes
libs/blocks/footer/footer.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

milo/libs/blocks/footer/footer.js

Line 349 in 82098c7

console.log(`Could not create footer: ${error}`);

github-actions[bot]
github-actions bot reviewed Dec 5, 2024
View reviewed changes
libs/blocks/footer/footer.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

milo/libs/blocks/footer/footer.js

Line 359 in 82098c7

console.log('Could not create footer.');

github-actions[bot]
github-actions bot reviewed Dec 5, 2024
View reviewed changes
libs/deps/mas/plans-modal.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Dec 5, 2024
View reviewed changes
libs/features/spectrum-web-components/dist/popover.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.57534% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.41%. Comparing base (8025cb7) to head (b72ed94).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
libs/navigation/navigation.js 91.30% 4 Missing ⚠️
libs/blocks/article-feed/article-feed.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3315      +/-   ##
==========================================
- Coverage   96.41%   96.41%   -0.01%     
==========================================
  Files         246      246              
  Lines       57492    57567      +75     
==========================================
+ Hits        55433    55504      +71     
- Misses       2059     2063       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mokimo
mokimo requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One PR will need to be pulled out from this tomorrow.

@tedAir tedAir self-requested a review December 9, 2024 06:32
@milo-pr-merge milo-pr-merge bot merged commit e51a18c into main Dec 9, 2024
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sigadamvenkata sigadamvenkata sigadamvenkata approved these changes

@Roycethan Roycethan Roycethan approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@mokimo mokimo mokimo approved these changes

@Dli3 Dli3 Dli3 approved these changes

@tedAir tedAir tedAir approved these changes

@ryanmparrish ryanmparrish Awaiting requested review from ryanmparrish

@elan-tbx elan-tbx Awaiting requested review from elan-tbx

@Sartxi Sartxi Awaiting requested review from Sartxi

@salonijain3 salonijain3 Awaiting requested review from salonijain3 salonijain3 is a code owner

@bandana147 bandana147 Awaiting requested review from bandana147 bandana147 is a code owner

@sharmrj sharmrj Awaiting requested review from sharmrj sharmrj is a code owner

@nishantka nishantka Awaiting requested review from nishantka nishantka is a code owner

@Deva309 Deva309 Awaiting requested review from Deva309 Deva309 is a code owner

@sonawanesnehal3 sonawanesnehal3 Awaiting requested review from sonawanesnehal3 sonawanesnehal3 is a code owner

@meganthecoder meganthecoder Awaiting requested review from meganthecoder meganthecoder is a code owner

@Brandon32 Brandon32 Awaiting requested review from Brandon32 Brandon32 is a code owner

@JasonHowellSlavin JasonHowellSlavin Awaiting requested review from JasonHowellSlavin JasonHowellSlavin is a code owner

@rgclayton rgclayton Awaiting requested review from rgclayton rgclayton is a code owner

Assignees
No one assigned
Labels
BAcom SOT 👌 CC SOT 👌 DC SOT 👌 Homepage SOT 👌 MIQ SOT👌
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.