Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-161273 Standalone Gnav needs a release cycle [Bundle] #3322

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Copy link
Contributor

aem-code-sync bot commented Dec 6, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Dec 6, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@spadmasa spadmasa self-assigned this Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (82098c7) to head (4ec39cf).
Report is 2 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3322      +/-   ##
==========================================
- Coverage   96.41%   96.41%   -0.01%     
==========================================
  Files         246      246              
  Lines       57568    57567       -1     
==========================================
- Hits        55505    55504       -1     
  Misses       2063     2063              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to bundled-standalone-gnav-fix December 6, 2024 05:12 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to bundled-standalone-gnav-fix December 6, 2024 05:12 Inactive
Copy link
Contributor

github-actions bot commented Dec 6, 2024

This PR does not qualify for the zero-impact label as it touches code outside of the allowed areas. The label is auto applied, do not manually apply the label.

@spadmasa
Copy link

spadmasa commented Dec 6, 2024

Validated the changes on the pr, details are added in the ticket
https://jira.corp.adobe.com/browse/MWPW-163734
https://main--bacom-blog--adobecom.hlx.page/blog/?milolibs=bundled-standalone-gnav-fix
image
Navigation on the links
image

image

https://main--blog--adobecom.hlx.page/?milolibs=bundled-standalone-gnav-fix
image
https://main--blog--adobecom.hlx.page/jp/
image

https://main--cc--adobecom.hlx.page/creativecloud?milolibs=bundled-standalone-gnav-fix
image

redirection on the link is working
image

Validation is done on bacom/blog and blog and regression on cc, dc,home and bacom

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Dec 6, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 6, 2024

Skipped 3322: "MWPW-161273 Standalone Gnav needs a release cycle [Bundle]" due to file "libs/blocks/global-footer/global-footer.js" overlap. Merging will be attempted in the next batch

@mokimo mokimo merged commit b2ec35a into stage Dec 6, 2024
24 checks passed
@mokimo mokimo deleted the bundled-standalone-gnav-fix branch December 6, 2024 08:51
@mokimo mokimo mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants