Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-162711][NALA] Update Table block tests to validate tooltip information #3267

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

skumar09
Copy link
Contributor

  • Validate tooltip information in table header rows
  • Validate tooltip information in table section rows
  • Add tests for new table variants
    * Table (merch, pricing-bottom)
    * Table (merch, button-right)

Resolves: MWPW-162711

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Nov 26, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (6f4d98c) to head (8733cfc).
Report is 35 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3267   +/-   ##
=======================================
  Coverage   96.37%   96.38%           
=======================================
  Files         245      245           
  Lines       56716    56716           
=======================================
+ Hits        54661    54666    +5     
+ Misses       2055     2050    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amauch-adobe amauch-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Dec 5, 2024
@milo-pr-merge milo-pr-merge bot merged commit 11b61cc into adobecom:stage Dec 5, 2024
20 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants