Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MWPW-161570] Ensure hardcoded decorative SVGs have aria-hidden="true" #3247

Merged
merged 8 commits into from
Dec 5, 2024
Merged

[MWPW-161570] Ensure hardcoded decorative SVGs have aria-hidden="true" #3247

merged 8 commits into from
Dec 5, 2024

Conversation

robert-bogos
Copy link
Contributor

@robert-bogos robert-bogos commented Nov 22, 2024 •
edited
Loading

Description

This PR add the aria-hidden="true" attribute to all decorative inline SVGs.

Related Issue

Resolves: MWPW-161570

Testing instructions

Check any inline SVG (e.g. the social icons from the footer), it should have the aria-hidden="true" attribute.

Screenshots:

Before:
Screenshot 2024-11-22 at 10 41 44

After:
Screenshot 2024-11-22 at 10 42 51

Test URLs

Milo:

@robert-bogos robert-bogos requested a review from a team November 22, 2024 08:45
@robert-bogos robert-bogos self-assigned this Nov 22, 2024
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Nov 22, 2024 •
edited
Loading

Page Scores Audits Google
📱 /drafts/rbogos/page-default?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/rbogos/page-default?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.39%. Comparing base (afe9047) to head (dec1e2d).
Report is 17 commits behind head on stage.

Files with missing lines Patch % Lines
libs/blocks/article-feed/article-feed.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            stage    #3247   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         245      245           
  Lines       56746    56746           
=======================================
  Hits        54698    54698           
  Misses       2048     2048

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

overmyheadandbody
overmyheadandbody reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this! I have a few notes.

libs/blocks/footer/footer.js Outdated Show resolved Hide resolved
libs/blocks/gnav/gnav.js Outdated Show resolved Hide resolved
libs/blocks/table-of-contents/table-of-contents.js Outdated Show resolved Hide resolved
libs/deps/mas/plans-modal.js Show resolved Hide resolved
libs/deps/plans-modal.js Outdated Show resolved Hide resolved
libs/features/spectrum-web-components/dist/icons-ui.js Outdated Show resolved Hide resolved
libs/features/spectrum-web-components/dist/icons-workflow.js Outdated Show resolved Hide resolved
libs/ui/controls/TagSelector.js Outdated Show resolved Hide resolved
@mokimo mokimo requested review from yesil and 3ch023 November 22, 2024 13:15
@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

NadiiaSokolova
NadiiaSokolova approved these changes Nov 25, 2024
View reviewed changes
Copy link

@NadiiaSokolova NadiiaSokolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-161570

overmyheadandbody
overmyheadandbody requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to address a few things before moving forward with this. Thanks for all the changes so far, @robert-bogos!

libs/blocks/global-footer/global-footer.js Outdated Show resolved Hide resolved
libs/blocks/gnav/gnav-appLauncher.js Outdated Show resolved Hide resolved
libs/deps/mas/plans-modal.js Show resolved Hide resolved
libs/deps/plans-modal.js Outdated Show resolved Hide resolved
overmyheadandbody
overmyheadandbody reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 more comment 🙈 Otherwise looks good, thanks!

libs/blocks/global-footer/global-footer.js Outdated Show resolved Hide resolved
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 3, 2024

Skipped 3247: "[MWPW-161570] Ensure hardcoded decorative SVGs have aria-hidden="true"" due to file "libs/blocks/aside/aside.js" overlap. Merging will be attempted in the next batch

overmyheadandbody
overmyheadandbody approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now 👍

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 4, 2024

Skipped 3247: "[MWPW-161570] Ensure hardcoded decorative SVGs have aria-hidden="true"" due to file "libs/blocks/global-footer/global-footer.js" overlap. Merging will be attempted in the next batch

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 4, 2024

Skipped 3247: "[MWPW-161570] Ensure hardcoded decorative SVGs have aria-hidden="true"" due to file "libs/blocks/aside/aside.js" overlap. Merging will be attempted in the next batch

@milo-pr-merge milo-pr-merge bot merged commit 023541d into adobecom:stage Dec 5, 2024
14 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NadiiaSokolova NadiiaSokolova NadiiaSokolova approved these changes

@mokimo mokimo mokimo approved these changes

@overmyheadandbody overmyheadandbody overmyheadandbody approved these changes

@Sartxi Sartxi Sartxi approved these changes

@ryanmparrish ryanmparrish ryanmparrish approved these changes

@Brandon32 Brandon32 Awaiting requested review from Brandon32 Brandon32 is a code owner

@meganthecoder meganthecoder Awaiting requested review from meganthecoder meganthecoder is a code owner

@JasonHowellSlavin JasonHowellSlavin Awaiting requested review from JasonHowellSlavin JasonHowellSlavin is a code owner

@elan-tbx elan-tbx Awaiting requested review from elan-tbx

@salonijain3 salonijain3 Awaiting requested review from salonijain3 salonijain3 is a code owner

@bandana147 bandana147 Awaiting requested review from bandana147 bandana147 is a code owner

@sharmrj sharmrj Awaiting requested review from sharmrj sharmrj is a code owner

@nishantka nishantka Awaiting requested review from nishantka nishantka is a code owner

@Deva309 Deva309 Awaiting requested review from Deva309 Deva309 is a code owner

@sonawanesnehal3 sonawanesnehal3 Awaiting requested review from sonawanesnehal3 sonawanesnehal3 is a code owner

@rgclayton rgclayton Awaiting requested review from rgclayton rgclayton is a code owner

@yesil yesil Awaiting requested review from yesil

@3ch023 3ch023 Awaiting requested review from 3ch023

Assignees

@robert-bogos robert-bogos

Labels
Ready for Stage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@robert-bogos @ryanmparrish @Sartxi @overmyheadandbody @mokimo @NadiiaSokolova