Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picking first string only for localnav title #3281

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

bandana147
Copy link
Contributor

As part of the new mobile redesign task, the mobile localnav requires the ability to override the title. To support this, we are introducing an overriding capability by allowing an additional string to be added to the title, e.g., "Photoshop | Overview."

This is a prerequisite task for the mobile redesign work, enabling authors to prepare their content before the mobile redesign code is merged.

Resolves: MWPW-163191

Test URLs:

Qa

@bandana147 bandana147 added the needs-verification PR requires E2E testing by a reviewer label Nov 29, 2024
Copy link
Contributor

aem-code-sync bot commented Nov 29, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Nov 29, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (6f4d98c) to head (da6cd8d).
Report is 35 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3281      +/-   ##
==========================================
+ Coverage   96.37%   96.38%   +0.01%     
==========================================
  Files         245      245              
  Lines       56716    56736      +20     
==========================================
+ Hits        54661    54686      +25     
+ Misses       2055     2050       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@prativas22
Copy link

@prativas22 prativas22 added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Dec 2, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 4, 2024

Skipped 3281: "Picking first string only for localnav title" due to file "libs/blocks/global-navigation/global-navigation.js" overlap. Merging will be attempted in the next batch

@milo-pr-merge milo-pr-merge bot merged commit 82098c7 into stage Dec 5, 2024
25 checks passed
@milo-pr-merge milo-pr-merge bot deleted the gnav-localnav-title branch December 5, 2024 17:23
@milo-pr-merge milo-pr-merge bot mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants