-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Picking first string only for localnav title #3281
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3281 +/- ##
==========================================
+ Coverage 96.37% 96.38% +0.01%
==========================================
Files 245 245
Lines 56716 56736 +20
==========================================
+ Hits 54661 54686 +25
+ Misses 2055 2050 -5 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Verified that the mobile localnav supports overriding the title by adding the first string to the title as a prerequisite for the mobile redesign . |
Skipped 3281: "Picking first string only for localnav title" due to file "libs/blocks/global-navigation/global-navigation.js" overlap. Merging will be attempted in the next batch |
As part of the new mobile redesign task, the mobile localnav requires the ability to override the title. To support this, we are introducing an overriding capability by allowing an additional string to be added to the title, e.g., "Photoshop | Overview."
This is a prerequisite task for the mobile redesign work, enabling authors to prepare their content before the mobile redesign code is merged.
Resolves: MWPW-163191
Test URLs:
Qa