Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of aria label text for links #3255

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Conversation

overmyheadandbody
Copy link
Contributor

This allows authors to set individual aria-label values for links in order to make them accessibility-compliant. A few things that were considered (also available on the test page):

  • certain links may have non-text children, such as icons;
  • some links may actually need to have a pipe in their text, so just the text after the last pipe is considered for the aria-label value;
  • I've queried a few projects for the presence of | inside links and came short, meaning there should be no links currently on production that would get affected by this change;

Resolves: MWPW-161396

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Nov 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Nov 25, 2024

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (6f4d98c) to head (adb15f1).
Report is 35 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3255      +/-   ##
==========================================
+ Coverage   96.37%   96.38%   +0.01%     
==========================================
  Files         245      245              
  Lines       56716    56744      +28     
==========================================
+ Hits        54661    54694      +33     
+ Misses       2055     2050       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

test/utils/mocks/body.html Show resolved Hide resolved
libs/utils/utils.js Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@NadiiaSokolova NadiiaSokolova self-assigned this Dec 4, 2024
Copy link

@NadiiaSokolova NadiiaSokolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-161396

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 4, 2024

Skipped 3255: "Allow setting of aria label text for links" due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch

@milo-pr-merge milo-pr-merge bot merged commit 7cc4058 into stage Dec 5, 2024
19 checks passed
@milo-pr-merge milo-pr-merge bot deleted the links-aria-label branch December 5, 2024 17:23
@milo-pr-merge milo-pr-merge bot mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants