-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting of aria label text for links #3255
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3255 +/- ##
==========================================
+ Coverage 96.37% 96.38% +0.01%
==========================================
Files 245 245
Lines 56716 56744 +28
==========================================
+ Hits 54661 54694 +33
+ Misses 2055 2050 -5 ☔ View full report in Codecov by Sentry. |
98a9c07
to
e563717
Compare
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Reminder to set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-161396
Skipped 3255: "Allow setting of aria label text for links" due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch |
This allows authors to set individual
aria-label
values for links in order to make them accessibility-compliant. A few things that were considered (also available on the test page):aria-label
value;|
inside links and came short, meaning there should be no links currently on production that would get affected by this change;Resolves: MWPW-161396
Test URLs: