Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix no cookie preference in stage #3309

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

swamu
Copy link
Contributor

@swamu swamu commented Dec 5, 2024

Context for this change:
The value of the cookie is set differently on stage and hlx.live.

What was happening:
Firing the api even when the cookies pref is disabled

What this change is doing:
NOT Firing the api even when the cookies pref is disabled

Enhance Interact call efficiency - fix cookie policy

Resolves: MWPW-158749

Test URLs:

Before: https://main--milo--adobecom.aem.page/?martech=on
After: https://stage-bug-fix--milo--swamu.aem.page/?martech=on

Copy link
Contributor

aem-code-sync bot commented Dec 5, 2024

Page Scores Audits Google
📱 /?martech=on PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=on PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (ac9010a) to head (cba09d8).
Report is 8 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3309   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         246      246           
  Lines       57565    57568    +3     
=======================================
+ Hits        55501    55504    +3     
  Misses       2064     2064           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swamu swamu added verified PR has been E2E tested by a reviewer high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage and removed verified PR has been E2E tested by a reviewer labels Dec 5, 2024
@sharg1 sharg1 added the needs-verification PR requires E2E testing by a reviewer label Dec 5, 2024
@milo-pr-merge milo-pr-merge bot merged commit ff58d7e into adobecom:stage Dec 5, 2024
36 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? needs-verification PR requires E2E testing by a reviewer Ready for Stage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants