Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Express SOTs #3287

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Add Express SOTs #3287

merged 1 commit into from
Dec 4, 2024

Conversation

overmyheadandbody
Copy link
Contributor

@overmyheadandbody overmyheadandbody commented Dec 2, 2024 •
edited
Loading

Add Express Team SOTs, now that they're joining the Milo family.

Test URLs:

@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (886aa3b) to head (13159cb).
Report is 15 commits behind head on stage.

Additional details and impacted files 
@@           Coverage Diff           @@
##            stage    #3287   +/-   ##
=======================================
  Coverage   96.38%   96.38%           
=======================================
  Files         245      245           
  Lines       56733    56733           
=======================================
  Hits        54683    54683           
  Misses       2050     2050

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Dec 2, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Dec 4, 2024

Error merging 3287: Add Express SOTs Resource not accessible by integration

@overmyheadandbody overmyheadandbody merged commit 91accb6 into adobecom:stage Dec 4, 2024
20 checks passed
@overmyheadandbody overmyheadandbody mentioned this pull request Dec 4, 2024
Merged
@overmyheadandbody overmyheadandbody deleted the update-members branch December 4, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhargrave vhargrave vhargrave approved these changes

@mokimo mokimo mokimo approved these changes

@narcis-radu narcis-radu narcis-radu approved these changes

@robert-bogos robert-bogos Awaiting requested review from robert-bogos

Assignees
No one assigned
Labels
Ready for Stage zero-impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@overmyheadandbody @narcis-radu @mokimo @vhargrave