[Release] Stage to Main #3300
Merged
[Release] Stage to Main #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![milo-pr-merge[bot]](https://avatars.githubusercontent.com/u/95242840?s=60&v=4){kind=small}
* bundled standalone gnav and footer * Fixed dark mode; load css from navigation.js * Refactored global footer to no longer use milo modal to render region-nav * global footer unit test * fix lint * Added keyboard navigation to the new region nav modal * export stuff from modal.js * replaced the new modal implementation with a more explicit usage of the current milo modal so that it can be bundled * code compatibility ignore pattern * Fix keyboard navigation unit tests * fixed footer unit test after changing the implementation of the region nav (again) * added sourcemaps; fixed dark mode issue * navigation unit tests * Cover uncovered lines in global-footer.js * prevent FOUC in region nav * built latest gnav changes * modified package.json to have a files field * use evergreen css for non-bundled and built css for bundled * Fixed region picker when there's no hash * Added a workflow to release standalone feds and removed dist from the PR * changed workflow_call to workflow_dispatch * Adjusted the cd command in the workflow * added a working directory * missed a space in the gh release upload command * added GITHUB_TOKEN to the upload asset step * fixed an error with file upload in the workflow * Removed a console.log from the build script; explicitly load fragment block in footer * Removed an unused import * Renamed a funciton in the build file and added a comment * Fixed region nav breaking on certain milo consumers * Fixed region nav breaking on some milo consumers for real this time * Removed an unused import * Added logic to not call the region nav code twice * unit test * modified a standalone footer unit test slightly * Removed a comment
…3124) * Adding dynamic-nav-group setting to allow distinction between dynamic-nav user journeys * Utils change * Ensuring status shows correctly dispite group * Making metadata case insensative
* top variant handler * adjust for requirements in sync * update to handle element justification for top variant
proxy marketing scripts for newsroom
|
Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot |
milo-pr-merge
bot
requested review from
salonijain3,
bandana147,
sharmrj,
nishantka,
Deva309 and
sonawanesnehal3
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3300 +/- ##
==========================================
+ Coverage 96.39% 96.41% +0.02%
==========================================
Files 245 246 +1
Lines 56746 57551 +805
==========================================
+ Hits 54698 55488 +790
- Misses 2048 2063 +15 ☔ View full report in Codecov by Sentry. |
* updated feature with accessibility code * video accessiblity added for carousels * added opt-out functionality * fixed linting errors * fixed unit test cases * fixed adobe tv issue * hover and focus added * controls positioned for rtl * hide-controls hash params added * how to block controls position bug fix * dark mode|bug fixes * code enhancement * pause-play bug mouse click bug fix * marquee dark mode|positioning fix * code enhancement * handled marquee backward compatiblity * Added placeholder for labels|indexed video aria-labels * aria-label added for hover play videos * async awaited decorateVideo in video.js and other linting errors * video indexes added * random video index and unit test cases updated * daa-ll is synced along with aria-label * code enhancement * nala test fix|code coverege * nala test bug fix * nala test fix * right-left positioning is done for screens > 600px and a img fix * getFedsconfig moved to feds file|url fetched from fedRoot function * linting fix * icons adapted to the figma * carousel and how-to fix with other minor fixes * playpause wrapper adjusted for window * icon offset bug fix * indentation of string literal * figma match * figma focus match
mokimo
requested review from
ryanmparrish,
Sartxi,
auniverseaway,
fullcolorcoder and
rgclayton
as code owners
There was a problem hiding this comment.
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.
#3302) * removed the /dist/ from the css paths where it's incorrect * Cover an uncovered line in tests
#3258) * move common snippets to helper, add defer logic and make interact call the 1st thing in the flow for signed out users * toggle FPID and ECID logic, re-organise exports, dont fire if consent cookie present * Pre merge branch (#5) move methods utils , use async load of helper, review comments * move try catch block as per promise * Pre merge branch (#6) * Test remove martech logic (#7) fix delay logic, fix pr comments * Test remove martech logic (#8) change uuid logic, promise structure, alloy response logic, requestid, * Final local branch (#9) fix review comments, add test cases * fix coverage for if check * fix coverage errors * add test case for martech helpers * send full cookie flag added post testing round 1
JackySun9
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
Roycethan
approved these changes
Dec 4, 2024
Roycethan
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
|
@JasonHowellSlavin We're having issues with the dynamic nav status not displaying on stage. |
Revert PR here: #3308 |
sigadamvenkata
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
sigadamvenkata
approved these changes
Dec 5, 2024
tedAir
approved these changes
Dec 5, 2024
* Fix: Adding prodDomains for standalone gnav * Fix: Adding allowedDomains for standalone gnav
Dli3
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: