Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-163606 removed the /dist/ from the css paths where it's incorrect #3302

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

sharmrj
Copy link
Contributor

@sharmrj sharmrj commented Dec 4, 2024

  • removed the /dist/ from the css paths where it's incorrect

Resolves: MWPW-163606

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Dec 4, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Dec 4, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sharmrj sharmrj requested a review from bandana147 December 4, 2024 10:40
@nishantka nishantka self-requested a review December 4, 2024 10:40
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (6e4138c) to head (94acebe).
Report is 2 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3302   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         245      245           
  Lines       56974    56974           
=======================================
  Hits        54920    54920           
  Misses       2054     2054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sharmrj
Copy link
Contributor Author

sharmrj commented Dec 4, 2024

Raised in stead of #3301

@spadmasa
Copy link

spadmasa commented Dec 4, 2024

PR can be verified only in stage. Adding the label to go to stage and test.

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage high priority Why is this a high priority? Blocker? Critical? Dependency? labels Dec 4, 2024
@sharmrj sharmrj changed the title removed the /dist/ from the css paths where it's incorrect MWPW-163606 removed the /dist/ from the css paths where it's incorrect Dec 4, 2024
@overmyheadandbody overmyheadandbody merged commit b632a21 into stage Dec 4, 2024
14 checks passed
@overmyheadandbody overmyheadandbody deleted the fix-css-dist-path branch December 4, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants