Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding prodDomains and allowed origin for standalone gnav #3310

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

@bandana147 bandana147 added the needs-verification PR requires E2E testing by a reviewer label Dec 5, 2024
Copy link
Contributor

aem-code-sync bot commented Dec 5, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Dec 5, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (ac9010a) to head (ab31057).
Report is 2 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3310      +/-   ##
==========================================
- Coverage   96.41%   96.40%   -0.01%     
==========================================
  Files         246      246              
  Lines       57565    57571       +6     
==========================================
+ Hits        55501    55502       +1     
- Misses       2064     2069       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spadmasa spadmasa added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Dec 5, 2024
@spadmasa spadmasa self-assigned this Dec 5, 2024
@spadmasa
Copy link

spadmasa commented Dec 5, 2024

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Dec 5, 2024
@bandana147
Copy link
Contributor Author

This is high priority as this is required for Adobe home ROW Standalone Gnav release on 6/12

@mokimo
Copy link
Contributor

mokimo commented Dec 5, 2024

Unrelated to the PR, but there is some CLS:
https://github.com/user-attachments/assets/8e939026-ac79-45bd-84b8-e66f4e49b308

@mokimo mokimo merged commit b6e67a7 into stage Dec 5, 2024
36 checks passed
@mokimo mokimo deleted the gnav-prodDomains branch December 5, 2024 13:15
@mokimo mokimo mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants