MWPW-163845: Merch-card a11y fix for CTAs #3403

yesil · 2024-12-20T11:07:17Z

Merch cards outside Milo, render checkout link styles using Spectrum CSS button for CCD.

With this change, I introduce a checkout-button customized built-in element (extending button) that can be styled directly using Spectrum CSS without having to wrap a a[is="checkout-link"]

⚠️ This PR will be pointed to stage once #3289 is merged.

Resolves:

Test URLs:

** Other pages: **

CCD gallery

aem-code-sync · 2024-12-20T11:07:21Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

dd6b228 ✅ (latest)
04abfa8 ✅
218c07f ✅
c993b11 ✅
1c7dae6 ✅
5abf2f3 ✅
330b40e ✅
ba675a4 ✅
d410d29 ✅
92ce654 ✅

aem-code-sync · 2024-12-20T11:07:34Z

	Page	Scores	Audits	Google
📱	/libs/features/mas/docs/ccd.html
🖥️	/libs/features/mas/docs/ccd.html
📱	/libs/features/mas/docs/mas.html
🖥️	/libs/features/mas/docs/mas.html

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/330b40ea3253db466df811fa7140dbd3420e5d82/libs/features/mas/src/utils.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/330b40ea3253db466df811fa7140dbd3420e5d82/libs/features/mas/src/variants/ccd-slice.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/330b40ea3253db466df811fa7140dbd3420e5d82/libs/features/mas/test/checkout-button.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/330b40ea3253db466df811fa7140dbd3420e5d82/libs/features/mas/test/checkout-link.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/330b40ea3253db466df811fa7140dbd3420e5d82/libs/features/mas/test/hydrate.test.js

libs/deps/mas/commerce.js

libs/deps/mas/mas.js

libs/deps/mas/merch-card.js

libs/deps/mas/merch-sidenav.js

libs/features/mas/dist/mas.js

libs/features/mas/src/checkout-button.js

libs/features/mas/src/checkout-link.js

libs/features/mas/src/checkout-mixin.js

libs/features/mas/src/commerce.js

github-actions · 2024-12-20T11:08:00Z

libs/features/mas/src/hydrate.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

libs/features/mas/docs/checkout-button.html

libs/features/mas/src/checkout-mixin.js

codecov · 2024-12-20T11:09:15Z

Codecov Report

Attention: Patch coverage is 96.65653% with 11 lines in your changes missing coverage. Please review.

Project coverage is 96.46%. Comparing base (69cfa63) to head (dd6b228).

Files with missing lines	Patch %	Lines
libs/features/mas/src/checkout-mixin.js	97.10%	7 Missing ⚠️
libs/features/mas/src/checkout-button.js	92.68%	3 Missing ⚠️
libs/features/mas/src/variants/ccd-suggested.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           MWPW-163479    #3403      +/-   ##
===============================================
- Coverage        96.47%   96.46%   -0.02%     
===============================================
  Files              254      256       +2     
  Lines            59090    59132      +42     
===============================================
+ Hits             57006    57040      +34     
- Misses            2084     2092       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-12-20T11:11:30Z

libs/features/mas/src/utils.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-20T11:11:31Z

libs/features/mas/src/variants/ccd-slice.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-20T11:11:32Z

libs/features/mas/test/checkout-button.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-20T11:11:33Z

libs/features/mas/test/checkout-link.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-20T11:11:34Z

libs/features/mas/test/hydrate.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-20T14:19:18Z

libs/features/mas/src/global.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-20T14:19:19Z

libs/features/mas/src/merch-card.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-20T14:19:19Z

libs/features/mas/src/variants/ccd-suggested.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

yesil added 4 commits December 19, 2024 20:39

WIP

92ce654

fix tabindex

d410d29

fix nala tests

ba675a4

MWPW-164484: fix see terms focus indicator

330b40e

yesil requested a review from a team as a code owner December 20, 2024 11:07

github-actions bot reviewed Dec 20, 2024

View reviewed changes

libs/deps/mas/commerce.js Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 20, 2024

View reviewed changes

libs/deps/mas/mas.js Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 20, 2024

View reviewed changes

libs/deps/mas/merch-card.js Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 20, 2024

View reviewed changes

libs/deps/mas/merch-sidenav.js Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 20, 2024

View reviewed changes

libs/features/mas/dist/mas.js Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 20, 2024

View reviewed changes

libs/features/mas/src/checkout-button.js Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 20, 2024

View reviewed changes

libs/features/mas/src/checkout-link.js Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 20, 2024

View reviewed changes

libs/features/mas/src/checkout-mixin.js Show resolved Hide resolved

github-actions bot reviewed Dec 20, 2024

View reviewed changes

libs/features/mas/src/commerce.js Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 20, 2024

View reviewed changes

github-advanced-security bot found potential problems Dec 20, 2024

View reviewed changes

libs/features/mas/docs/checkout-button.html Dismissed Show dismissed Hide dismissed

libs/features/mas/src/checkout-mixin.js Dismissed Show dismissed Hide dismissed

MWPW-164484: fix see terms focus indicator

5abf2f3

github-actions bot reviewed Dec 20, 2024

View reviewed changes

increase codecov

1c7dae6

github-actions bot reviewed Dec 20, 2024

View reviewed changes

yesil added 2 commits December 20, 2024 15:29

Update doc

c993b11

Update doc

218c07f

aem-code-sync bot temporarily deployed to MWPW-163845 December 20, 2024 14:36 Inactive

rename constant

04abfa8

aem-code-sync bot temporarily deployed to MWPW-163845 December 20, 2024 15:42 Inactive

Restrict updateLinks to spectrum css

dd6b228

aem-code-sync bot deployed to MWPW-163845 December 23, 2024 14:17 View deployment

yesil mentioned this pull request Dec 24, 2024

MWPW-161354: MAS: export variant metadata #3408

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-163845: Merch-card a11y fix for CTAs #3403

MWPW-163845: Merch-card a11y fix for CTAs #3403

yesil commented Dec 20, 2024 •

edited

Loading

aem-code-sync bot commented Dec 20, 2024 •

edited

Loading

aem-code-sync bot commented Dec 20, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot Dec 20, 2024

codecov bot commented Dec 20, 2024 •

edited

Loading

github-actions bot Dec 20, 2024

github-actions bot Dec 20, 2024

github-actions bot Dec 20, 2024

github-actions bot Dec 20, 2024

github-actions bot Dec 20, 2024

github-actions bot Dec 20, 2024

github-actions bot Dec 20, 2024

github-actions bot Dec 20, 2024

MWPW-163845: Merch-card a11y fix for CTAs #3403

Are you sure you want to change the base?

MWPW-163845: Merch-card a11y fix for CTAs #3403

Conversation

yesil commented Dec 20, 2024 • edited Loading

aem-code-sync bot commented Dec 20, 2024 • edited Loading

aem-code-sync bot commented Dec 20, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 20, 2024

Choose a reason for hiding this comment

codecov bot commented Dec 20, 2024 • edited Loading

Codecov Report

github-actions bot Dec 20, 2024

Choose a reason for hiding this comment

github-actions bot Dec 20, 2024

Choose a reason for hiding this comment

github-actions bot Dec 20, 2024

Choose a reason for hiding this comment

github-actions bot Dec 20, 2024

Choose a reason for hiding this comment

github-actions bot Dec 20, 2024

Choose a reason for hiding this comment

github-actions bot Dec 20, 2024

Choose a reason for hiding this comment

github-actions bot Dec 20, 2024

Choose a reason for hiding this comment

github-actions bot Dec 20, 2024

Choose a reason for hiding this comment

yesil commented Dec 20, 2024 •

edited

Loading

aem-code-sync bot commented Dec 20, 2024 •

edited

Loading

aem-code-sync bot commented Dec 20, 2024 •

edited

Loading

codecov bot commented Dec 20, 2024 •

edited

Loading