MWPW-161354: MAS: export variant metadata #3408

yesil · 2024-12-24T12:55:26Z

to allow MAS Studio to toggle the fields
in the editor.

⚠️ this PR will point to stage once #3403 is merged to stage.

Resolves: MWPW-161354

Test URLs:

** Other pages: **

https://mwpw-161354--milo--adobecom.aem.live/libs/features/mas/docs/ccd.html

to allow MAS Studio to toggle the fields in the editor.

aem-code-sync · 2024-12-24T12:55:29Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

1db0ed1 ✅ (latest)
c8d111b ✅
a254a9f ✅
d440b5c ✅
bde755c ✅

aem-code-sync · 2024-12-24T12:55:42Z

	Page	Scores	Audits	Google
📱	/libs/features/mas/docs/ccd.html
🖥️	/libs/features/mas/docs/ccd.html
📱	/libs/features/mas/docs/mas.html
🖥️	/libs/features/mas/docs/mas.html

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bde755c5a7c21f38fa5c657d43e4220ecf18159b/libs/features/mas/test/merch-card.ccd-suggested.test.html.js

github-actions · 2024-12-24T12:55:58Z

libs/deps/mas/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-24T12:55:59Z

libs/deps/mas/merch-card.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-24T12:56:00Z

libs/features/mas/dist/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-24T12:56:01Z

libs/features/mas/src/merch-card.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-24T12:56:02Z

libs/features/mas/src/variants/catalog.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-24T12:56:03Z

libs/features/mas/src/variants/ccd-slice.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-24T12:56:04Z

libs/features/mas/src/variants/ccd-suggested.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-24T12:56:05Z

libs/features/mas/src/variants/special-offer.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-24T12:56:06Z

libs/features/mas/src/variants/variants.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-24T12:56:07Z

libs/features/mas/test/hydrate.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

codecov · 2024-12-24T12:56:34Z

Codecov Report

Attention: Patch coverage is 95.94595% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.44%. Comparing base (dd6b228) to head (1db0ed1).

Files with missing lines	Patch %	Lines
libs/features/mas/src/merch-card.js	90.47%	2 Missing ⚠️
libs/features/mas/src/variants/special-offer.js	50.00%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           MWPW-163845    #3408      +/-   ##
===============================================
- Coverage        96.46%   96.44%   -0.02%     
===============================================
  Files              256      256              
  Lines            59132    59177      +45     
===============================================
+ Hits             57040    57074      +34     
- Misses            2092     2103      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-12-24T15:36:36Z

libs/features/mas/test/merch-card.ccd-suggested.test.html.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-24T16:06:04Z

libs/deps/mas/merch-icon.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-24T16:06:05Z

libs/features/mas/src/hydrate.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-12-24T16:06:06Z

libs/features/mas/src/merch-icon.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

MWPW-161354: export variant metadata

bde755c

to allow MAS Studio to toggle the fields in the editor.

yesil changed the title ~~MWPW-161354: export variant metadata~~ MWPW-161354: MAS: export variant metadata Dec 24, 2024

github-actions bot reviewed Dec 24, 2024

View reviewed changes

improve styles

d440b5c

aem-code-sync bot temporarily deployed to MWPW-161354 December 24, 2024 15:36 Inactive

github-actions bot reviewed Dec 24, 2024

View reviewed changes

yesil added 2 commits December 24, 2024 16:45

improve styles

a254a9f

improve styles

c8d111b

aem-code-sync bot temporarily deployed to MWPW-161354 December 24, 2024 15:56 Inactive

add eager loading for images and icons

1db0ed1

aem-code-sync bot deployed to MWPW-161354 December 24, 2024 16:05 View deployment

github-actions bot reviewed Dec 24, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-161354: MAS: export variant metadata #3408

MWPW-161354: MAS: export variant metadata #3408

yesil commented Dec 24, 2024 •

edited

Loading

aem-code-sync bot commented Dec 24, 2024 •

edited

Loading

aem-code-sync bot commented Dec 24, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

codecov bot commented Dec 24, 2024 •

edited

Loading

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

github-actions bot Dec 24, 2024

MWPW-161354: MAS: export variant metadata #3408

Are you sure you want to change the base?

MWPW-161354: MAS: export variant metadata #3408

Conversation

yesil commented Dec 24, 2024 • edited Loading

aem-code-sync bot commented Dec 24, 2024 • edited Loading

aem-code-sync bot commented Dec 24, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

codecov bot commented Dec 24, 2024 • edited Loading

Codecov Report

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot Dec 24, 2024

Choose a reason for hiding this comment

yesil commented Dec 24, 2024 •

edited

Loading

aem-code-sync bot commented Dec 24, 2024 •

edited

Loading

aem-code-sync bot commented Dec 24, 2024 •

edited

Loading

codecov bot commented Dec 24, 2024 •

edited

Loading