Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-161923] tab nested focus #3407

Merged
merged 7 commits into from
Jan 23, 2025
Merged

[MWPW-161923] tab nested focus #3407

merged 7 commits into from
Jan 23, 2025

Conversation

DKos95
Copy link
Contributor

@DKos95 DKos95 commented Dec 24, 2024

This resolves the issue where the buttons were nested in a div and not selectable with keyboard and screenreader, which is needed for accessability.

Resolves: MWPW-161923

Before After
Screenshot 2024-12-24 at 13 09 00 Screenshot 2024-12-24 at 13 07 49
Screenshot 2024-12-24 at 13 16 01 Screenshot 2024-12-24 at 13 16 21

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Dec 24, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Dec 24, 2024

Page Scores Audits Google
📱 /docs/library/kitchen-sink/tab-block PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /docs/library/kitchen-sink/tab-block PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (95d3ce2) to head (a056ab7).
Report is 27 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3407      +/-   ##
==========================================
- Coverage   96.46%   96.46%   -0.01%     
==========================================
  Files         255      255              
  Lines       59430    59420      -10     
==========================================
- Hits        57329    57318      -11     
- Misses       2101     2102       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

libs/blocks/tabs/tabs.css Outdated Show resolved Hide resolved
libs/blocks/tabs/tabs.css Outdated Show resolved Hide resolved
libs/blocks/tabs/tabs.css Outdated Show resolved Hide resolved
Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Narcis' comments are all valid, I have another note as well

libs/blocks/tabs/tabs.css Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to tab-nested-focus January 14, 2025 09:25 Inactive
Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now, but our a11y partners are hinting that we might have additional issues to solve. I've requested details and will follow up.

Copy link
Contributor

@narcis-radu narcis-radu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thank you!

@NadiiaSokolova NadiiaSokolova self-assigned this Jan 22, 2025
Copy link

@NadiiaSokolova NadiiaSokolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-161923

@milo-pr-merge milo-pr-merge bot merged commit 4d69057 into stage Jan 23, 2025
19 checks passed
@milo-pr-merge milo-pr-merge bot deleted the tab-nested-focus branch January 23, 2025 08:53
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants