-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-161923] tab nested focus #3407
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3407 +/- ##
==========================================
- Coverage 96.46% 96.46% -0.01%
==========================================
Files 255 255
Lines 59430 59420 -10
==========================================
- Hits 57329 57318 -11
- Misses 2101 2102 +1 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
bfad103
to
7f7f566
Compare
7f7f566
to
f6654d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Narcis' comments are all valid, I have another note as well
332cab0
to
a056ab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now, but our a11y partners are hinting that we might have additional issues to solve. I've requested details and will follow up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-161923
This resolves the issue where the buttons were nested in a div and not selectable with keyboard and screenreader, which is needed for accessability.
Resolves: MWPW-161923
Test URLs: