Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #3531

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[Release] Stage to Main #3531

wants to merge 12 commits into from

Conversation

drashti1712 and others added 9 commits January 23, 2025 08:53
increased coverage

Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.corp.adobe.com>
…nt Menu fields (#3494)

* Added data-cs-mask on elements that contain sensitive information

* Added data-cs-mask to the the outermost feds-profile element
)

* Changing logic based on requirement

* Removing console log
* MWPW-152155 Product & Image Card Widths: Merch Cards - Consonant Parity

* MWPW-152160 Product Card gray divider line Padding: Merch Cards - Consonant Parity

* Trigger Build

* Trigger Build

* MWPW-152160 Product Card gray divider line Padding: Merch Cards - Consonant Parity

* Build mas and merch-card

* Trigger Build

* Build mas

* Trigger Build

* MWPW-152160 Product Card gray divider line Padding: Merch Cards - Consonant Parity

* MWPW-152160 Product Card gray divider line Padding: Merch Cards - Consonant Parity

* Trigger Build

* Rebuild mas

* Trigger Build

---------

Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
* [MWPW-161923] tab nested focus

* [MWPW-161923] tab focus nala test fix

* [MWPW-161923] tab focus nala test fix

* [MWPW-161923] test coverage fix

* [MWPW-161923] aria-valuenow remove, new test adapted

* [MWPW-161923] no spacing fix

* [MWPW-161923] pr comments fix
* Tooltip tab-able.

* adding role as button to tooltip icon

* Tooltip: adding eventListner for enter to focus

* remove the event listener
#3459)

* MWPW-164871 Milo Products Catalog - A11Y - Elements must meet minimum color contrast ratio thresholds

* MWPW-164871 Milo Products Catalog - A11Y - Elements must meet minimum color contrast ratio thresholds

* Trigger Build

* Trigger Build

* Trigger Build

---------

Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
* Fixed potential repetative API calls

* Fixed potential repetative API calls

* Fixed potential repetative API calls

---------

Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
MWPW-164458: Breadcrumb has capital I in iPhone
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Jan 23, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

Copy link
Contributor

aem-code-sync bot commented Jan 23, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 23, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 97.09544% with 7 lines in your changes missing coverage. Please review.

Project coverage is 96.47%. Comparing base (a4101ed) to head (6cb26a3).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
libs/features/mas/src/price/template.js 87.09% 4 Missing ⚠️
libs/features/mas/src/price/utilities.js 97.61% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3531      +/-   ##
==========================================
- Coverage   96.47%   96.47%   -0.01%     
==========================================
  Files         260      260              
  Lines       60415    60582     +167     
==========================================
+ Hits        58284    58444     +160     
- Misses       2131     2138       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mokimo mokimo deployed to milo_pr_merge January 27, 2025 04:17 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.