Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip icon to be tabbed and showing the tooltip #3431

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Conversation

Copy link
Contributor

aem-code-sync bot commented Jan 7, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 7, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@seanchoi-dev seanchoi-dev added the run-nala Run Nala Test Automation against PR label Jan 7, 2025
@seanchoi-dev seanchoi-dev requested a review from mokimo January 7, 2025 22:16
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (a4101ed) to head (dc6a9e2).
Report is 9 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3431      +/-   ##
==========================================
- Coverage   96.47%   96.46%   -0.02%     
==========================================
  Files         260      260              
  Lines       60415    60417       +2     
==========================================
- Hits        58284    58279       -5     
- Misses       2131     2138       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@npeltier npeltier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seanchoi-dev seanchoi-dev added the needs-verification PR requires E2E testing by a reviewer label Jan 8, 2025
Copy link

@Roycethan Roycethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanchoi-dev
Although now info icon is foccussed using keyboard, its not operable using Enter/Spacebar, one of the other requirement #2 is to Open and Close the tooltip info by using Enter/Spacebar
ex:https://main--dc--adobecom.hlx.live/acrobat/pricing?martech=off&milolibs=MWPW-162384

Note : Similar one is fixed by Bozo for Titan Plans modal in this ticket : https://jira.corp.adobe.com/browse/MWPW-163873

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@Roycethan Roycethan added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Jan 21, 2025
@milo-pr-merge milo-pr-merge bot merged commit 2fe3f8b into stage Jan 23, 2025
25 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-162384 branch January 23, 2025 08:53
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants