-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip icon to be tabbed and showing the tooltip #3431
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3431 +/- ##
==========================================
- Coverage 96.47% 96.46% -0.02%
==========================================
Files 260 260
Lines 60415 60417 +2
==========================================
- Hits 58284 58279 -5
- Misses 2131 2138 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanchoi-dev
Although now info icon is foccussed using keyboard, its not operable using Enter/Spacebar, one of the other requirement #2 is to Open and Close the tooltip info by using Enter/Spacebar
ex:https://main--dc--adobecom.hlx.live/acrobat/pricing?martech=off&milolibs=MWPW-162384
Note : Similar one is fixed by Bozo for Titan Plans modal in this ticket : https://jira.corp.adobe.com/browse/MWPW-163873
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Resolves: MWPW-162384
Test URLs:
Test for consumer URLs: