MWPW-165302: Calculate promo prices with duration #3492

yesil · 2025-01-15T17:02:52Z

This PR introduces additional annual price logic calculation based on the promotion display details in the WCS response.

Resolves: MWPW-165302

Screenshots

Test URLs:

aem-code-sync · 2025-01-15T17:02:55Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

985222f ✅ (latest)
7af0f95 ✅
603a868 ✅
5746cfe ✅
1c3c921 ✅
10c498c ✅

aem-code-sync · 2025-01-15T17:03:15Z

	Page	Scores	Audits	Google
📱	/au/drafts/ilyas/inline-price?martech=off
🖥️	/au/drafts/ilyas/inline-price?martech=off

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/10c498cdb71e713bac7183210c3de3a8d9c3db25/libs/features/mas/test/price/template.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/10c498cdb71e713bac7183210c3de3a8d9c3db25/libs/features/mas/test/price/utilities.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/10c498cdb71e713bac7183210c3de3a8d9c3db25/libs/features/mas/test/utilities.js

github-actions · 2025-01-15T17:03:23Z

libs/deps/mas/commerce.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-15T17:03:24Z

libs/deps/mas/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-15T17:03:25Z

libs/features/mas/dist/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-15T17:03:26Z

libs/features/mas/src/price/index.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-15T17:03:27Z

libs/features/mas/src/price/template.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-15T17:03:28Z

libs/features/mas/src/price/utilities.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-15T17:03:29Z

libs/features/mas/test/price.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-15T17:03:29Z

libs/features/mas/test/price/__snapshots__/index.snapshot.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-15T17:03:30Z

libs/features/mas/test/price/__snapshots__/template.snapshots.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-15T17:03:31Z

libs/features/mas/test/price/index.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

codecov · 2025-01-15T17:03:53Z

Codecov Report

Attention: Patch coverage is 95.62500% with 7 lines in your changes missing coverage. Please review.

Project coverage is 96.47%. Comparing base (cf48942) to head (985222f).
Report is 1 commits behind head on stage.

Files with missing lines	Patch %	Lines
libs/features/mas/src/price/template.js	87.09%	4 Missing ⚠️
libs/features/mas/src/price/utilities.js	97.61%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #3492      +/-   ##
==========================================
- Coverage   96.47%   96.47%   -0.01%     
==========================================
  Files         260      260              
  Lines       60445    60582     +137     
==========================================
+ Hits        58314    58444     +130     
- Misses       2131     2138       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2025-01-15T17:07:10Z

libs/features/mas/test/price/template.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-15T17:07:11Z

libs/features/mas/test/price/utilities.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-15T17:07:12Z

libs/features/mas/test/utilities.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

libs/features/mas/src/price/utilities.js

github-actions · 2025-01-18T01:24:36Z

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

Roycethan · 2025-01-23T02:00:34Z

@yesil Verified , plz resolve the JS conflicts thanks

milo-pr-merge · 2025-01-23T08:53:59Z

Skipped 3492: "MWPW-165302: Calculate promo prices with duration" due to file "libs/deps/mas/mas.js" overlap. Merging will be attempted in the next batch

github-actions · 2025-01-23T09:05:34Z

libs/deps/mas/merch-card.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

MWPW-165302: Calculate promo prices with duration

10c498c

github-actions bot reviewed Jan 15, 2025

View reviewed changes

update jsdoc

1c3c921

aem-code-sync bot temporarily deployed to MWPW-165302 January 15, 2025 17:06 Inactive

github-actions bot reviewed Jan 15, 2025

View reviewed changes

fix test

5746cfe

aem-code-sync bot temporarily deployed to MWPW-165302 January 15, 2025 17:27 Inactive

yesil requested a review from a team January 15, 2025 17:35

yesil added the commerce label Jan 15, 2025

fix recurrence

603a868

bozojovicic reviewed Jan 16, 2025

View reviewed changes

libs/features/mas/src/price/utilities.js Show resolved Hide resolved

bozojovicic approved these changes Jan 16, 2025

View reviewed changes

3ch023 approved these changes Jan 17, 2025

View reviewed changes

Roycethan added the verified PR has been E2E tested by a reviewer label Jan 23, 2025

Roycethan added the Ready for Stage label Jan 23, 2025

Merge branch 'stage' of github.com:adobecom/milo into MWPW-165302

7af0f95

github-actions bot reviewed Jan 23, 2025

View reviewed changes

Merge branch 'stage' of github.com:adobecom/milo into MWPW-165302

985222f

overmyheadandbody merged commit 6cb26a3 into stage Jan 23, 2025
13 checks passed

overmyheadandbody deleted the MWPW-165302 branch January 23, 2025 09:39

overmyheadandbody mentioned this pull request Jan 23, 2025

[Release] Stage to Main #3531

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-165302: Calculate promo prices with duration #3492

MWPW-165302: Calculate promo prices with duration #3492

yesil commented Jan 15, 2025 •

edited

Loading

aem-code-sync bot commented Jan 15, 2025 •

edited

Loading

aem-code-sync bot commented Jan 15, 2025 •

edited

Loading

github-actions bot left a comment

github-actions bot Jan 15, 2025

github-actions bot Jan 15, 2025

github-actions bot Jan 15, 2025

github-actions bot Jan 15, 2025

github-actions bot Jan 15, 2025

github-actions bot Jan 15, 2025

github-actions bot Jan 15, 2025

github-actions bot Jan 15, 2025

github-actions bot Jan 15, 2025

github-actions bot Jan 15, 2025

codecov bot commented Jan 15, 2025 •

edited

Loading

github-actions bot Jan 15, 2025

github-actions bot Jan 15, 2025

github-actions bot Jan 15, 2025

github-actions bot commented Jan 18, 2025

Roycethan commented Jan 23, 2025

milo-pr-merge bot commented Jan 23, 2025

github-actions bot Jan 23, 2025

MWPW-165302: Calculate promo prices with duration #3492

MWPW-165302: Calculate promo prices with duration #3492

Conversation

yesil commented Jan 15, 2025 • edited Loading

aem-code-sync bot commented Jan 15, 2025 • edited Loading

aem-code-sync bot commented Jan 15, 2025 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

codecov bot commented Jan 15, 2025 • edited Loading

Codecov Report

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

github-actions bot Jan 15, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 18, 2025

Roycethan commented Jan 23, 2025

milo-pr-merge bot commented Jan 23, 2025

github-actions bot Jan 23, 2025

Choose a reason for hiding this comment

yesil commented Jan 15, 2025 •

edited

Loading

aem-code-sync bot commented Jan 15, 2025 •

edited

Loading

aem-code-sync bot commented Jan 15, 2025 •

edited

Loading

codecov bot commented Jan 15, 2025 •

edited

Loading