Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-164458: Fix - Breadcrumb has capital I in iPhone #3499

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

nishantka
Copy link
Contributor

Adds the option for adding a modifier no-transform in breadcrumbs which will retains text case instead of capitalizing first letter by default.

Resolves: MWPW-164458

Test URLs:

QA: https://mwpw-164458--milo--adobecom.hlx.page/drafts/nishantkaush/gnav/breadcrumb

Copy link
Contributor

aem-code-sync bot commented Jan 16, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 16, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/nishantkaush/gnav/breadcrumb PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/nishantkaush/gnav/breadcrumb PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (6eb0401) to head (bbeaee7).
Report is 17 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3499   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         258      258           
  Lines       60150    60152    +2     
=======================================
+ Hits        58029    58031    +2     
  Misses       2121     2121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the authoring docs with this possibility within the breadcrumbs.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@spadmasa
Copy link

Validation done on the pr on the below urls in milo and cc
https://mwpw-164458--milo--adobecom.hlx.page/drafts/nishantkaush/gnav/breadcrumb
verified after authoring update
https://main--cc--adobecom.hlx.page/drafts/souj/app?milolibs=mwpw-164458
image
https://adobe.sharepoint.com/:x:/r/sites/adobecom/_layouts/15/Doc.aspx?sourcedoc=%7B4399ab29-c207-432b-9b51-376cc55947dd%7D&action=editnew
https://main--cc--adobecom.hlx.page/drafts/souj/breadcrumb.json

https://main--cc--adobecom.hlx.page/tools/loc?milolibs=locui&ref=main&repo=cc&owner=adobecom&host=www.adobe.com&project=Creative+Cloud&referrer=https%3A%2F%2Fadobe.sharepoint.com%2F%3Ax%3A%2Fr%2Fsites%2Fadobecom%2F_layouts%2F15%2FDoc.aspx%3Fsourcedoc%3D%257B4399ab29-c207-432b-9b51-376cc55947dd%257D%26action%3Deditnew

validation done on the below url
https://main--cc--adobecom.hlx.page/drafts/souj/breadcrumb?milolibs=MWPW-164458
image
https://main--cc--adobecom.hlx.page/es/drafts/souj/breadcrumb?milolibs=MWPW-164458
image
https://main--cc--adobecom.hlx.page/tw/drafts/souj/breadcrumb?milolibs=mwpw-164458
https://main--cc--adobecom.hlx.page/hk_zh/drafts/souj/breadcrumb?milolibs=MWPW-164458
https://main--cc--adobecom.hlx.page/cn/drafts/souj/breadcrumb?milolibs=MWPW-164458

https://main--cc--adobecom.hlx.page/tr/drafts/souj/breadcrumb?milolibs=MWPW-164458
https://main--cc--adobecom.hlx.page/pl/drafts/souj/breadcrumb?milolibs=MWPW-164458
https://main--cc--adobecom.hlx.page/kr/drafts/souj/breadcrumb?milolibs=MWPW-164458
https://main--cc--adobecom.hlx.page/cz/drafts/souj/breadcrumb?milolibs=MWPW-164458
https://main--cc--adobecom.hlx.page/jp/drafts/souj/breadcrumb?milolibs=MWPW-164458
https://main--cc--adobecom.hlx.page/fr/drafts/souj/breadcrumb?milolibs=MWPW-164458
https://main--cc--adobecom.hlx.page/ca_fr/drafts/souj/breadcrumb?milolibs=MWPW-164458

cc : @sigadamvenkata @prativas22 @nishantka @salonijain3

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 21, 2025
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 21, 2025

Skipped 3499: "MWPW-164458: Fix - Breadcrumb has capital I in iPhone" due to file "libs/blocks/global-navigation/global-navigation.css" overlap. Merging will be attempted in the next batch

@milo-pr-merge milo-pr-merge bot merged commit 7d4a28d into stage Jan 23, 2025
24 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-164458 branch January 23, 2025 08:54
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants