-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-164458: Fix - Breadcrumb has capital I in iPhone #3499
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3499 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 258 258
Lines 60150 60152 +2
=======================================
+ Hits 58029 58031 +2
Misses 2121 2121 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to update the authoring docs with this possibility within the breadcrumbs.
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Skipped 3499: "MWPW-164458: Fix - Breadcrumb has capital I in iPhone" due to file "libs/blocks/global-navigation/global-navigation.css" overlap. Merging will be attempted in the next batch |
Adds the option for adding a modifier
no-transform
in breadcrumbs which will retains text case instead of capitalizing first letter by default.Resolves: MWPW-164458
Test URLs:
QA: https://mwpw-164458--milo--adobecom.hlx.page/drafts/nishantkaush/gnav/breadcrumb