Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing unit tests for branch-quick-links.js #3515

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

drashti1712
Copy link
Contributor

  • Fixed and added unit tests to increase code coverage of branch-quick-links.js

Resolves: MWPW-164132

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Jan 21, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (e4558c9) to head (60743dd).
Report is 5 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3515      +/-   ##
==========================================
- Coverage   96.46%   96.45%   -0.01%     
==========================================
  Files         260      260              
  Lines       60417    60417              
==========================================
- Hits        58281    58276       -5     
- Misses       2136     2141       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drashti1712 drashti1712 changed the title Fixing unit tests to increase the code coverage Fixing unit tests for branch-quick-links.js Jan 21, 2025
@spadmasa
Copy link

No validation needed , pr is for UT coverage , adding the label.

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 22, 2025
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 22, 2025

Skipped 3515: "Fixing unit tests for branch-quick-links.js" due to file "test/features/branch-quick-links/branch-quick-links.test.js" overlap. Merging will be attempted in the next batch

@milo-pr-merge milo-pr-merge bot merged commit 20c69b3 into adobecom:stage Jan 23, 2025
30 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer zero-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants