MWPW-146930 - Rollout Tool Plugin - environment specific miloLibs #3516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sabyamon
requested review from
narcis-radu,
nkthakur48,
overmyheadandbody,
saurabhsircar11,
mokimo and
raga-adbe-gh
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3516 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 260 260
Lines 60415 60419 +4
=======================================
+ Hits 58284 58288 +4
Misses 2131 2131 ☔ View full report in Codecov by Sentry. |
saurabhsircar11
approved these changes
Jan 21, 2025
raga-adbe-gh
approved these changes
Jan 21, 2025
nkthakur48
approved these changes
Jan 21, 2025
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
sigadamvenkata
added
verified
|
Skipped merging 3516: MWPW-146930 - Rollout Tool Plugin - environment specific miloLibs due to failing or running checks |
sabyamon
force-pushed
the
rollout-tool-update
branch
from
0542658 to
53d685c
Compare
salonijain3
added
the
high priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup of #3463.
Updating
miloLibsbased on environment selected. Special case for Milo where the branch needs to be overridden.Resolves: https://jira.corp.adobe.com/browse/MWPW-146930
Test URLs:
Before: https://main--milo--adobecom.aem.page/?martech=off
After: https://rollout-tool-update--milo--sabyamon.hlx.page/?martech=off
This feature can be tested in Milo and in BACOM by selecting the Test project configuration locally and providing the URL
https://rollout-tool-update--milo--sabyamon.hlx.page