Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merge-to-stage worfklow] Increase Github APIs listReview per_page limit #3519

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

mokimo
Copy link
Contributor

@mokimo mokimo commented Jan 21, 2025

Description

It can happen that the merge-to-stage workflow doesn't correctly identify reviews for a PR due to limitations on the github APIs. By increasing the limit from the default 30 to 100 on the list review endpoint we should be very unlikely to run into a scenario where a PR has 2 approvals but we can't know due to pagination limits.

We ran into this on two occasions that I know of with a limit of 30, so with a limit of 100 we can be virtually "safe" from PRs preventing to get merged due to "insufficient approvals" by misdetection.

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Jan 21, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 21, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.

@mokimo mokimo changed the title increase page limit for pr reviews [Merge-to-stage worfklow] Increase Github APIs listReview per_page limit Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (a4101ed) to head (cdeb6f4).
Report is 10 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3519   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         260      260           
  Lines       60415    60415           
=======================================
  Hits        58284    58284           
  Misses       2131     2131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@mokimo mokimo merged commit 0a1793a into stage Jan 23, 2025
15 checks passed
@mokimo mokimo deleted the improve-pr-checks branch January 23, 2025 09:16
@mokimo mokimo mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants