[Merge-to-stage worfklow] Increase Github APIs listReview per_page limit #3519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It can happen that the
merge-to-stage
workflow doesn't correctly identify reviews for a PR due to limitations on the github APIs. By increasing the limit from the default 30 to 100 on the list review endpoint we should be very unlikely to run into a scenario where a PR has 2 approvals but we can't know due to pagination limits.We ran into this on two occasions that I know of with a limit of 30, so with a limit of 100 we can be virtually "safe" from PRs preventing to get merged due to "insufficient approvals" by misdetection.
Test URLs: