List accessibility for quiz-marquee #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Before submitting, please review all open PRs. --> * Update quiz-marquee authoring to denote nested lists * roles for list and listitem in quiz-marquee and quiz-results Resolves: [MWPW-165027](https://jira.corp.adobe.com/browse/165027-NUMBER)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3460 +/- ##
==========================================
- Coverage 96.46% 96.46% -0.01%
==========================================
Files 255 255
Lines 59363 59432 +69
==========================================
+ Hits 57266 57331 +65
- Misses 2097 2101 +4 ☔ View full report in Codecov by Sentry. |
fullcolorcoder
approved these changes
Jan 10, 2025
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
sabyamon
reviewed
Jan 12, 2025
sabyamon
reviewed
Jan 12, 2025
sabyamon
approved these changes
Jan 12, 2025
JackySun9
approved these changes
Jan 13, 2025
JackySun9
added
verified
rgclayton
approved these changes
Jan 13, 2025
|
Skipped merging 3460: List accessibility for quiz-marquee due to failing checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-165027
Test URLs:
Testing Notes:
In order to test this change properly, an entry in local storage will need to be created after initially viewing the before and after pages. Set a local storage entry using the following:
Key: quiz-test-en-US
Value: {"primaryProducts":["stager-ind"],"secondaryProducts":["ps-ind","ai-ind","ae-ind"],"umbrellaProduct":"","basicFragments":["https://uar-integration--milo--adobecom.hlx.live/fragments/xiasun/sample-uar-fragments/single-product/single-product-master","https://uar-integration--milo--adobecom.hlx.live/fragments/xiasun/sample-uar-fragments/card/card-list"],"nestedFragments":{"marquee-product-single":[""],"check-bullet":["https://milo.adobe.com/fragments/xiasun/sample-uar-fragments/check-bullet/stager-bullet3","https://milo.adobe.com/fragments/xiasun/sample-uar-fragments/check-bullet/stager-bullet2","https://milo.adobe.com/fragments/xiasun/sample-uar-fragments/check-bullet/stager-bullet3"],"marquee-plan":["https://milo.adobe.com/fragments/xiasun/sample-uar-fragments/master-plan/substance-3d-stager-ind"],"value-prop":["https://milo.adobe.com/fragments/xiasun/sample-uar-fragments/value-prop/value-prop-stager"],"learn":["https://main--milo--adobecom.hlx.live/fragments/xiasun/sample-uar-fragments/learn/learn"],"commerce-card":["https://main--milo--adobecom.hlx.live/fragments/xiasun/sample-uar-fragments/card/ps","https://main--milo--adobecom.hlx.live/fragments/xiasun/sample-uar-fragments/card/ai","https://main--milo--adobecom.hlx.live/fragments/xiasun/sample-uar-fragments/card/ae"]},"pageloadHash":"type=cc:app-reco&quiz=uarv3&result=stager-ind&selectedOptions=q-category/3d|q-3d/stage|q-customer/individual"}
Note that in the before page, the list of checked bullets (classed as "nested check-bullet show") do not have role="list" and the contained fragments do not have role="listitem". Both roles are present on the after page.