Don't merge PRs with running tests #3481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3481 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 255 255
Lines 59430 59430
=======================================
Hits 57329 57329
Misses 2101 2101 ☔ View full report in Codecov by Sentry. |
npeltier
approved these changes
Jan 14, 2025
|
@mokimo could you please update with the latest stage as well? Nala tests are failing because there is no latest version of the tests/page version |
mokimo
force-pushed
the
safeguard-pr-merges
branch
from
4697d96 to
084928d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@npeltier pointed out that #3460 got merged with failing tests. This is because the workflow to merge to stage, ran while I restarted the tests for #3460. We need to account for running tests as well.
Test URLs: