-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-160808: fassform is seen displayed without the #id and not able to close #3471
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3471 +/- ##
==========================================
- Coverage 96.47% 96.46% -0.02%
==========================================
Files 258 258
Lines 60150 60150
==========================================
- Hits 58029 58022 -7
- Misses 2121 2128 +7 ☔ View full report in Codecov by Sentry. |
@sivasadobe |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
db0589b
to
126e834
Compare
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
Hi Team, I have verified the PR. This PR resolves the issue. Tested the URLs with the fix. Before: After: |
Fixed the issue where the modal would open even when no hash value was present in the URL
Resolves: MWPW-160808
Test URLs:
Milo
CC