-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] Stage to Main #3581
[Release] Stage to Main #3581
Conversation
* MWPW-166012: ABM text styling on suggested card * updated deps * Add styling for 'ccd-suggested' variant in merch-card component * Removed css not required
…to close (#3471) * fix(modal): fixed modal opens even no hash val in url * chore: removed condition
…ibutes of merch card (#3505) * Adding aria label for CTA using placeholder on name attributes of the card. * Adding aria-label for checkout-link using productFamily as placeholder key * change the key to label * adding card-heading * adding unit test for aria-label * nit adding hypens * new logic for catalog * change the logic: checking URL to matching * update the test to avoid fail * nit: remove console.log * use cardheading instead label when they are same * Moving the logic into merch.js * nit:remove trailing space * Using customerSegment from WCS. * nit: comment update * Using placeholder for customer segment. * Adding EDU as special use case
Add empty space if the logo is undefined
Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot |
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3581 +/- ##
==========================================
+ Coverage 96.48% 96.49% +0.01%
==========================================
Files 260 260
Lines 60808 60826 +18
==========================================
+ Hits 58671 58696 +25
+ Misses 2137 2130 -7 ☔ View full report in Codecov by Sentry. |
) * fixed the flaky test for logWebVitalsUtils.test.js (#1) * fixed the flaky test * move performance mock to beforeEach/afterEach for isolation, simplify lcpElType check * removed unused code * fixed the same issue in logWebVitals.test.js and reverted unnecessary changes * Update fstab.yaml * Update fstab.yaml * Update fstab.yaml * Update fstab.yaml * Update fstab.yaml * removed dependency on gist.github.com by mocking script request * replaced setTimeout to prevent flakiness * Replaced Promise.resolve().then() with setTimeout() * earlier return for if statement * Improve callback matching in script mock * improve event loop handling * Replaced IIFE with async
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: