Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #3581

Merged
merged 6 commits into from
Jan 30, 2025
Merged

[Release] Stage to Main #3581

merged 6 commits into from
Jan 30, 2025

Conversation

Axelcureno and others added 5 commits January 29, 2025 18:01
* MWPW-166012: ABM text styling on suggested card

* updated deps

* Add styling for 'ccd-suggested' variant in merch-card component

* Removed css not required
…to close (#3471)

* fix(modal): fixed modal opens even no hash val in url

* chore: removed condition
…ibutes of merch card (#3505)

* Adding aria label for CTA using placeholder on name attributes of the card.

* Adding aria-label for checkout-link using productFamily as placeholder key

* change the key to label

* adding card-heading

* adding unit test for aria-label

* nit adding hypens

* new logic for catalog

* change the logic: checking URL to matching

* update the test to avoid fail

* nit: remove console.log

* use cardheading instead label when they are same

* Moving the logic into merch.js

* nit:remove trailing space

* Using customerSegment from WCS.

* nit: comment update

* Using placeholder for customer segment.

* Adding EDU as special use case
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Jan 29, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

Copy link
Contributor

aem-code-sync bot commented Jan 29, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 29, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (56128d6) to head (c12af33).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3581      +/-   ##
==========================================
+ Coverage   96.48%   96.49%   +0.01%     
==========================================
  Files         260      260              
  Lines       60808    60826      +18     
==========================================
+ Hits        58671    58696      +25     
+ Misses       2137     2130       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

)

* fixed the flaky test for logWebVitalsUtils.test.js (#1)

* fixed the flaky test

* move performance mock to beforeEach/afterEach for isolation, simplify lcpElType check

* removed unused code

* fixed the same issue in logWebVitals.test.js and reverted unnecessary changes

* Update fstab.yaml

* Update fstab.yaml

* Update fstab.yaml

* Update fstab.yaml

* Update fstab.yaml

* removed dependency on gist.github.com by mocking script request

* replaced setTimeout to prevent flakiness

* Replaced Promise.resolve().then() with setTimeout()

* earlier return for if statement

* Improve callback matching in script mock

* improve event loop handling

* Replaced IIFE with async
@milo-pr-merge milo-pr-merge bot merged commit 2d31710 into main Jan 30, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.