Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-166012: [CCD - Suggested Cards] Enable ABM text under price #3520

Open
wants to merge 1 commit into
base: stage
Choose a base branch
from

Conversation

Axelcureno
Copy link
Member

@Axelcureno Axelcureno commented Jan 21, 2025

Allows authors to include the legend "Annual, paid monthly" next to the price in CCD suggested cards as part of a legal requirement.

Screenshot 2025-01-21 at 3 04 04 PM Screenshot 2025-01-21 at 3 07 00 PM

Resolves: MWPW-166012

Mas link: https://main--mas--adobecom.hlx.page/studio.html?milolibs=MWPW-166012--milo--adobecom#path=drafts

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Jan 21, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 21, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (a4101ed) to head (bef3210).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3520      +/-   ##
==========================================
- Coverage   96.47%   96.44%   -0.03%     
==========================================
  Files         260      260              
  Lines       60415    60419       +4     
==========================================
- Hits        58284    58273      -11     
- Misses       2131     2146      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Roycethan
Copy link

Roycethan commented Jan 24, 2025

@Axelcureno Milo regressions are covered and

  1. I see figma mentioning following
    Name Body/Sans/Sans XS
    Font Adobe Clean
    Weight 400
    Style italic
    Size 12px
    Line height 18px
    Color: #464646
image

In the authored card - can make it Italic but other properties are not matched:
https://main--mas--adobecom.hlx.page/studio.html?milolibs=MWPW-166012--milo--adobecom#path=drafts
image
image

  1. Plz resolve conflicts at libs/deps/mas/merch-card.js

fyi @afmicka

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants