Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-166012: [CCD - Suggested Cards] Enable ABM text under price #3520

Open
wants to merge 4 commits into
base: stage
Choose a base branch
from
+40 −4
Open

MWPW-166012: [CCD - Suggested Cards] Enable ABM text under price #3520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bef3210
MWPW-166012: ABM text styling on suggested card
Axelcureno Jan 21, 2025
c99fada
Merge branch 'stage' into MWPW-166012
Axelcureno Jan 27, 2025
1621cf8
updated deps
Axelcureno Jan 27, 2025
f1e3b4e
Add styling for 'ccd-suggested' variant in merch-card component
Axelcureno Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion libs/deps/mas/mas.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 10 additions & 1 deletion libs/deps/mas/merch-card.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Original file line number Diff line number Diff line change
Expand Up @@ -1412,6 +1412,11 @@ merch-card[variant='twp'] merch-offer-select {
line-height: var(--consonant-merch-card-body-xxs-line-height);
}

merch-card[variant="ccd-suggested"] [slot="price"] em {
font-size: var(--consonant-merch-card-body-xxs-font-size);
line-height: var(--consonant-merch-card-body-xxs-line-height);
}

.spectrum--darkest merch-card[variant="ccd-suggested"] {
--consonant-merch-card-background-color:rgb(30, 30, 30);
--consonant-merch-card-heading-xs-color:rgb(239, 239, 239);
Expand Down Expand Up @@ -1531,7 +1536,11 @@ merch-card[variant='twp'] merch-offer-select {
:host([variant='ccd-suggested']) ::slotted([slot='price']) {
font-size: var(--consonant-merch-card-body-xs-font-size);
line-height: var(--consonant-merch-card-body-xs-line-height);
min-width: fit-content;
}

:host([variant='ccd-suggested']) ::slotted([slot='price']) em {
font-size: var(--consonant-merch-card-body-xxs-font-size);
line-height: var(--consonant-merch-card-body-xxs-line-height);
}

:host([variant='ccd-suggested']) ::slotted([slot='cta']) {
Expand Down
11 changes: 10 additions & 1 deletion libs/features/mas/dist/mas.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions libs/features/mas/src/variants/ccd-suggested.css.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ export const CSS = `
line-height: var(--consonant-merch-card-body-xxs-line-height);
}

merch-card[variant="ccd-suggested"] [slot="price"] em {
font-size: var(--consonant-merch-card-body-xxs-font-size);
line-height: var(--consonant-merch-card-body-xxs-line-height);
}

.spectrum--darkest merch-card[variant="ccd-suggested"] {
--consonant-merch-card-background-color:rgb(30, 30, 30);
--consonant-merch-card-heading-xs-color:rgb(239, 239, 239);
Expand Down
6 changes: 5 additions & 1 deletion libs/features/mas/src/variants/ccd-suggested.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,11 @@ export class CCDSuggested extends VariantLayout {
:host([variant='ccd-suggested']) ::slotted([slot='price']) {
font-size: var(--consonant-merch-card-body-xs-font-size);
line-height: var(--consonant-merch-card-body-xs-line-height);
min-width: fit-content;
}

:host([variant='ccd-suggested']) ::slotted([slot='price']) em {
font-size: var(--consonant-merch-card-body-xxs-font-size);
line-height: var(--consonant-merch-card-body-xxs-line-height);
}

:host([variant='ccd-suggested']) ::slotted([slot='cta']) {
Expand Down
Loading