-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-165793] aside temporary double background check added #3514
base: stage
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3514 +/- ##
========================================
Coverage 96.46% 96.47%
========================================
Files 259 260 +1
Lines 60217 60415 +198
========================================
+ Hits 58090 58284 +194
- Misses 2127 2131 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good..
Reminder to set the |
This adds a double check for the background color allowing us to change color via authoring after merge without bringing down tests for everyone else and fixing the accessibility color contrast issue. After merging and authoring the background color, a new PR will be made to revert back to checking only the single new background color.
Resolves: MWPW-165793
Test URLs: