Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-165793] aside temporary double background check added #3514

Open
wants to merge 3 commits into
base: stage
Choose a base branch
from

Conversation

DKos95
Copy link
Contributor

@DKos95 DKos95 commented Jan 20, 2025

This adds a double check for the background color allowing us to change color via authoring after merge without bringing down tests for everyone else and fixing the accessibility color contrast issue. After merging and authoring the background color, a new PR will be made to revert back to checking only the single new background color.

Resolves: MWPW-165793

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Jan 20, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 20, 2025

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (66f90cb) to head (ae1f453).
Report is 15 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff            @@
##            stage    #3514    +/-   ##
========================================
  Coverage   96.46%   96.47%            
========================================
  Files         259      260     +1     
  Lines       60217    60415   +198     
========================================
+ Hits        58090    58284   +194     
- Misses       2127     2131     +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@skumar09 skumar09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good..

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants