Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-165793] aside temporary double background check added #3514

Merged
merged 3 commits into from
Jan 27, 2025
Merged

[MWPW-165793] aside temporary double background check added #3514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99d9723
[MWPW-165793] aside temporary double background check added
DKos95 Jan 20, 2025
9c1c5e6
[MWPW-165793] changing used for check
DKos95 Jan 22, 2025
ae1f453
[MWPW-165793] change color used for test
DKos95 Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions nala/blocks/aside/aside.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ test.describe('Aside Block test suite', () => {
const bgdColor = await Aside.asideSmall.evaluate(
(e) => window.getComputedStyle(e).getPropertyValue('background-color'),
);
expect(bgdColor).toBe(Aside.props.background.lightGrey1);
expect([Aside.props.background.lightGrey1, Aside.props.background.lightGrey3]).toContain(bgdColor);
});

await test.step('step-3: Verify the accessibility test on the Aside Small block', async () => {
Expand Down Expand Up @@ -69,7 +69,7 @@ test.describe('Aside Block test suite', () => {
expect(await Aside.actionButtons.count()).toEqual(2);
// Check Aside block background:
const bgdColor = await Aside.asideMedium.evaluate((e) => window.getComputedStyle(e).getPropertyValue('background-color'));
expect(bgdColor).toBe(Aside.props.background.lightGrey1);
expect([Aside.props.background.lightGrey1, Aside.props.background.lightGrey3]).toContain(bgdColor);
});

await test.step('step-3: Verify the accessibility test on the Aside Medium block', async () => {
Expand Down Expand Up @@ -103,7 +103,7 @@ test.describe('Aside Block test suite', () => {
expect(await Aside.actionButtons.count()).toEqual(2);
// Check Aside block background:
const bgdColor = await Aside.asideLarge.evaluate((e) => window.getComputedStyle(e).getPropertyValue('background-color'));
expect(bgdColor).toBe(Aside.props.background.lightGrey1);
expect([Aside.props.background.lightGrey1, Aside.props.background.lightGrey3]).toContain(bgdColor);
});

await test.step('step-3: Verify the accessibility test on the Aside Large block', async () => {
Expand Down
2 changes: 1 addition & 1 deletion test/blocks/aside/aside.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe('aside', () => {

it('allows a background color', async () => {
const el = await waitForElement('#test-default');
expect(window.getComputedStyle(el)?.backgroundColor).to.equal('rgb(238, 238, 238)');
expect(window.getComputedStyle(el)?.backgroundColor).to.be.oneOf(['rgb(249, 249, 249)', 'rgb(238, 238, 238)']);
});

it('allows a background image', async () => {
Expand Down
Loading