Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-166355 [MEP] Number and symbols are very small in MEP button on RTL pages #3541

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

vgoodric
Copy link
Contributor

  • Override font family for MEP button because it stays in English and the font family for RTL languages makes the numbers and symbols the wrong size

Resolves: MWPW-166355

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Jan 24, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 24, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (6cb26a3) to head (814a0c5).
Report is 1 commits behind head on mepstage.

Additional details and impacted files
@@             Coverage Diff              @@
##           mepstage    #3541      +/-   ##
============================================
+ Coverage     96.47%   96.48%   +0.01%     
============================================
  Files           260      260              
  Lines         60582    60582              
============================================
+ Hits          58444    58451       +7     
+ Misses         2138     2131       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markpadbe markpadbe self-requested a review January 24, 2025 18:34
@vgoodric vgoodric added Ready for Stage verified PR has been E2E tested by a reviewer labels Jan 24, 2025
@vgoodric vgoodric changed the base branch from stage to mepstage January 24, 2025 19:08
@vgoodric vgoodric merged commit 2f2a6dd into mepstage Jan 24, 2025
23 checks passed
@vgoodric vgoodric deleted the meprtlnumbers branch January 24, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants