Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-166355, 166002, 159369, 156867 [MEP] Batch PR #3542

Open
wants to merge 4 commits into
base: stage
Choose a base branch
from
Open

Conversation

vgoodric and others added 4 commits January 24, 2025 12:09
…n Target experience is chosen (#3527)

* Added server vs target manifest handling

* refactored a bit

* refactored test

---------

Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
* stash

* ready to publish

* interact call coming back but timing out

* working on a fast connection

* clean up ifs

* working with promise

* use camel case on let variable

* unit tests

* create mepxlg branch

* update library

* require full hostname match

* update reference for unit test

* update unit tests

* switch to use config instead of domain list and stub response in unit test

* update fetch to 2

* updating another fetch to 2

* restore normalizePath to use preview domains on preview links

* preload segment list json

* use getFederatedUrl instead

* import at top so we don't have to make normalizePath async

* add federated link function to registerInBlockActions

* add to unit test

* initial commit

* stash commit

* remove dupe valMap const

* update test files

* linting error fix

---------

Co-authored-by: vgoodric <vgoodric@adobe.com>
Copy link
Contributor

aem-code-sync bot commented Jan 24, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 24, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (6cb26a3) to head (085c7f3).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3542      +/-   ##
==========================================
+ Coverage   96.47%   96.48%   +0.01%     
==========================================
  Files         260      260              
  Lines       60582    60599      +17     
==========================================
+ Hits        58444    58468      +24     
+ Misses       2138     2131       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgoodric vgoodric added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants