generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-166355, 166002, 159369, 156867 [MEP] Batch PR #3542
Open
vgoodric
wants to merge
4
commits into
stage
Choose a base branch
from
mepstage
base: stage
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RTL pages (#3541) update font family
…n Target experience is chosen (#3527) * Added server vs target manifest handling * refactored a bit * refactored test --------- Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
* add sample rate * change error type
* stash * ready to publish * interact call coming back but timing out * working on a fast connection * clean up ifs * working with promise * use camel case on let variable * unit tests * create mepxlg branch * update library * require full hostname match * update reference for unit test * update unit tests * switch to use config instead of domain list and stub response in unit test * update fetch to 2 * updating another fetch to 2 * restore normalizePath to use preview domains on preview links * preload segment list json * use getFederatedUrl instead * import at top so we don't have to make normalizePath async * add federated link function to registerInBlockActions * add to unit test * initial commit * stash commit * remove dupe valMap const * update test files * linting error fix --------- Co-authored-by: vgoodric <vgoodric@adobe.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3542 +/- ##
==========================================
+ Coverage 96.47% 96.48% +0.01%
==========================================
Files 260 260
Lines 60582 60599 +17
==========================================
+ Hits 58444 58468 +24
+ Misses 2138 2131 -7 ☔ View full report in Codecov by Sentry. |
ivanvatadobe
approved these changes
Jan 24, 2025
markpadbe
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains updates from 4 fully verified and reviewed PRs:
Resolves: MWPW-166355
MWPW-166002
MWPW-159369
MWPW-156867
Test URLs: