Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-159369 [cc][LANA] Error reported: target response time: 0.5 #3475

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

vgoodric
Copy link
Contributor

Copy link
Contributor

aem-code-sync bot commented Jan 14, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 14, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (746f58e) to head (716c6ef).
Report is 38 commits behind head on mepstage.

Additional details and impacted files
@@            Coverage Diff            @@
##           mepstage    #3475   +/-   ##
=========================================
  Coverage     96.46%   96.46%           
=========================================
  Files           255      255           
  Lines         59431    59434    +3     
=========================================
+ Hits          57330    57333    +3     
  Misses         2101     2101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Jan 23, 2025
@vgoodric vgoodric added Ready for Stage verified PR has been E2E tested by a reviewer labels Jan 24, 2025
@vgoodric vgoodric changed the base branch from stage to mepstage January 24, 2025 19:08
@vgoodric vgoodric merged commit 0080957 into mepstage Jan 24, 2025
24 checks passed
@vgoodric vgoodric deleted the mepreducelana branch January 24, 2025 19:10
milo-pr-merge bot pushed a commit that referenced this pull request Jan 28, 2025
* MWPW-166355 [MEP] Number and symbols are very small in MEP button on RTL pages (#3541)

update font family

* MWPW-166002 | [MEP] Use Target served version of manifest in prod when Target experience is chosen (#3527)

* Added server vs target manifest handling

* refactored a bit

* refactored test

---------

Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>

* MWPW-159369 [cc][LANA] Error reported: target response time: 0.5 (#3475)

* add sample rate

* change error type

* MWPW-156867 [MILO][MEP][ANALYTICS] Support Column nicknames (#3510)

* stash

* ready to publish

* interact call coming back but timing out

* working on a fast connection

* clean up ifs

* working with promise

* use camel case on let variable

* unit tests

* create mepxlg branch

* update library

* require full hostname match

* update reference for unit test

* update unit tests

* switch to use config instead of domain list and stub response in unit test

* update fetch to 2

* updating another fetch to 2

* restore normalizePath to use preview domains on preview links

* preload segment list json

* use getFederatedUrl instead

* import at top so we don't have to make normalizePath async

* add federated link function to registerInBlockActions

* add to unit test

* initial commit

* stash commit

* remove dupe valMap const

* update test files

* linting error fix

---------

Co-authored-by: vgoodric <vgoodric@adobe.com>

* MWPW-166639 [MEP] Removing OST links doesn't work when MEP button is on (#3556)

exclude ost links from highlight

---------

Co-authored-by: Denys Fedotov <denlight@gmail.com>
Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
Co-authored-by: Jan Ivan Viloria <158211769+ivanvatadobe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage Stale verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants