Crypto test original target now allows to run kereberos tests

[judovana]

if both
SKIP_AGENT_TESTS=false
AGENT_HOSTNAME=some.krb.enabled.agent
are provided, the 5 kerberos based tests will run too

part of #5246

[judovana]

https://ci.adoptium.net/view/Test_grinder/job/Grinder/9710/

[llxia]

CryptoTests is limited to vendor=redhat. Please use Red Hat SDK in Grinder for testing.

[judovana]

It shuld not be. Both targets should be available to all vendors. The diffference requiring second target was in OS, not JDK.

[llxia]

Running identical tests twice within a build inefficiently consumes both machine and triage resources. Please be aware that we may execute these tests across various versions/platforms/impls multiple times daily. It's essential to strictly limit duplicate tests.

We have already discussed this in #5206 and #5240 (comment)

If your perspective differs, please feel free to have additional discussion in #5206

[judovana]

https://ci.adoptium.net/view/Test_grinder/job/Grinder/9715/

[judovana]

Running identical tests twice within a build inefficiently consumes both machine and triage resources. Please be aware that we may execute these tests across various versions/platforms/impls multiple times daily. It's essential to strictly limit duplicate tests.

We have already discussed this in #5206 and #5240 (comment)

If your perspective differs, please feel free to have additional discussion in #5206

ok.

CryptoTests is limited to vendor=redhat. Please use Red Hat SDK in Grinder for testing.

What is the magical keyword and where to write that please?

[llxia]

What is the magical keyword and where to write that please?

There is no magical keyword. We just need to run CryptoTests with Red Hat SDK. It means setting the URL via CUSTOMIZED_SDK_URL in Grinder.

[judovana]

What is the magical keyword and where to write that please?

There is no magical keyword. We just need to run CryptoTests with Red Hat SDK. It means setting the URL via CUSTOMIZED_SDK_URL in Grinder.

TYVm!

[judovana]

Gosh. It seems to be biting our own tail - https://ci.adoptium.net/view/Test_grinder/job/Grinder/9721/console - the RH jdk is behind adoptium-marketplace login it seems.

[judovana]

Hmm.. tis one https://ci.adoptium.net/view/Test_grinder/job/Grinder/9722/ was from own mirror. Any ideas?

[smlambert]

SDK_RESOURCE=customized

but it won't matter, because #4374
(no other vendors package .xz, so we have not yet needed to support it)

[judovana]

Ah. Sure. TY!

[judovana]

I had repacked the file by gz but https://ci.adoptium.net/view/Test_grinder/job/Grinder/9744/console still fails. It seems tobe downloading, but there is no trace to failure. Also I had noticed possibly buggy behaviour: #5254

[judovana]

Fixed ginder (thanx @smlambert !) https://ci.adoptium.net/view/Test_grinder/job/Grinder/9797/ is green

[judovana]

Thanx, can we mere now please?

[karianna]

@llxia Will need to re-review first.

[llxia]

Where do we set SKIP_AGENT_TESTS and AGENT_HOSTNAME?

[judovana]

We don't, but user should be able to do so.

Eg I have agent created, so I will pass it on before launching aqavit, and crypto tests it will run also kerberos tests.

I'm working on ability to set up local kerberos server before starting the suite, and although i have setup of it done, it is still very distatn future.

[llxia]

The check is in https://github.com/rh-openjdk/CryptoTest/blob/master/run.sh#L124. Instead of adding if [ "x${SKIP_AGENT_TESTS}" = "x" ] ; then export SKIP_AGENT_TESTS=1 ; fi ; \ , I think we just need to remove the hardcoded line SKIP_AGENT_TESTS=1 in the original playlist <command>.

[judovana]

Thanx for eyball! I'm definitely ok to adjsut run.sh, but as yo wrote it it somehow do not fit.
I would actually like to rework all the SKIP_AGENT_TESTS/AGENT_HOSTNAME but it is so wide spread... But Maybe I need just bigger poke:)

The global idea should be:

• the kerberos tests in CryptoTests are on by Default
  • but one must provide AGENT_HOSTNAME
  • the suite should yield if there is no host name and they are on
• they can be easily disabled by SKIP_AGENT_TESTS set to "false"

Afaik it is how it is now

In aqa-tests

• the kerberos tests shoudl be disabled by default, unless user enables them
  • if they are enabled, one must extrnaly provide AGENT_HOSTNAME
• It should not reintroduce new variable, the SKIP_AGENT_TESTS shoudl be reused.

Which I hope this PR is doing.

So IIUC, dropping of SKIP_AGENT_TESTS=1 in original play-lists will evolve to fail in both cases.

[judovana]

Ping please?

[llxia]

approve this is partial change for #5246.