Made both CryptoTests_jtreg and CryptoTests targets vendor neutral

[judovana]

It is passing for all vendors, the differences lies in underlyng OS, not JDK

[judovana]

However, as pointed out in #5248 (review) they must have no intersection on platforms/OSes

I would like to return CryptoTest target to be vendor neutral, and correclty run on platforms where it can.
On all other platforms - or generally anywhere where @llxia needs it - it should run the new CryptoTests_jtreg

Can you help me to set up platforms properly or is this out of cope?

[smlambert]

Add a disable tag to the CryptoTests target at line 38

<disable>
	<comment>This target is for those using jtreg-plugin, and wanting the extra functionality provided by run.sh, tarring of results, downloading of bespoke jtreg.jar</comment>
</disable>

That way you can run it with _disabled.CryptoTests and others will not be running the test material twice.

[judovana]

Thanx, that is already much more friendly, Will continue with it. TY!

[smlambert]

This comment is inappropriate, please fix it with the suggested sentence instead of using loaded terms and phrases. For the record, it is not only for the issue on s390x that others do not want to use run.sh, it is precisely because it has a bunch of extra behaviour that is unneeded and unwanted by those using AQAvit Jenkins pipelines.

[judovana]

Sure, I will try to elaborate on it. However there is no single word lying. Maybe except ancient s390x platforms . Although the s390x was the only platform I was able to get close reproduce the issue. On MACs it was working fine.

I can not agree that ability to enable the kerberos based thest is unwanted. The only disputable part was tarring of jtr.xml files, where I offered that I will add support for both.
Similarly I think that any possible user should be warned that run.sh is what is used in git hub actions.

As I stated before, I would much more likely create the original target with the original launcher to be usefull for anybody (and I committed myself to it) then do any forking. But it have been already decided.

[smlambert]

Fact-based:
<comment>This target is for those using GH actions or the Jenkins jtreg-plugin. The run.sh script provides extra functionality, tarring of results, downloading of bespoke jtreg.jar from a particular untagged commit SHA that is not yet upstreamed to a release version of jtreg that is used to set up some kerberos tests.</comment>

[judovana]

Fact-based: <comment>This target is for those using GH actions or the Jenkins jtreg-plugin. The run.sh script provides extra functionality, tarring of results, downloading of bespoke jtreg.jar from a particular untagged commit SHA that is not yet upstreamed to a release version of jtreg that is used to set up some kerberos tests.</comment>

Thank you and sorry for being nit picky about that. It i ok by me, except the tail where is error.

-is not yet upstreamed to a release version of jtreg that is used to set up some kerberos tests
+is not yet upstreamed to a release version of jtreg that is used see complete output in jtr.xml files. In addition it simplify enable/disable of kerberos-based tests which needs remote, pre-set KDC.  

wdyt?

[judovana]

Thanx a lot for patience! Ok by me if I have permissions to say anything to it. TY!

[smlambert]

This is still in draft mode. I can move it out to merge @judovana if you have made your final edits.

[judovana]

Thanx, can we mere now please?