-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnixPB: Temporarily fix CentOS6 Adoptopenjdk_install role #1913
Conversation
Note: Don't want to merge this until specifically @sxa has seen / reviewed this |
Doesn't look it worked? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This says "Temporarily" ... Does that mean there's a plan to have a proper fix somewhere? I really don't want to leave anything like this in place ...
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/adoptopenjdk_install/tasks/main.yml
Outdated
Show resolved
Hide resolved
The check look like it failed when building the docker image .. The playbook should be fixed with this PR, but I'll look at that issue next :-)
I'll continue working on it - the initial thought was to have CentOS6 update Python to 2.7.9 at the beginning of the playbook, but that causes extra issues. What I've tried is in the referenced issue |
…k_install/tasks/main.yml Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
Converting to Draft as I figure out the Dockerfile issue |
Looks like upgrading pip has fixed the Dockerfile issue. I'm not sure why the Ansible_Lint check is failing - it seems to not like |
ansible-lint failure has been raised #1926 as it's not just affecting this PR, so do not consider that a blocker. |
NOTE TO REVIEWERS: Discussion currently continuing in #1877 |
@sxa should we put this in draft? |
Closing as #1970 is better |
ref: #1877
This is a temporary fix, to get the Docker C6 and VPC checks working for now- given that the requests are to our API server, I'm less scared about not validating those certs.
Checklist