Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnixPB: Temporarily fix CentOS6 Adoptopenjdk_install role #1913

Closed
wants to merge 5 commits into from

Conversation

Willsparker
Copy link
Contributor

ref: #1877

This is a temporary fix, to get the Docker C6 and VPC checks working for now- given that the requests are to our API server, I'm less scared about not validating those certs.

Checklist

@Willsparker Willsparker added this to the February 2021 milestone Feb 9, 2021
@Willsparker Willsparker requested a review from sxa February 9, 2021 09:30
@Willsparker Willsparker self-assigned this Feb 9, 2021
@Willsparker
Copy link
Contributor Author

Note: Don't want to merge this until specifically @sxa has seen / reviewed this

@karianna
Copy link
Contributor

Note: Don't want to merge this until specifically @sxa has seen / reviewed this

Doesn't look it worked?

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says "Temporarily" ... Does that mean there's a plan to have a proper fix somewhere? I really don't want to leave anything like this in place ...

@Willsparker
Copy link
Contributor Author

Doesn't look it worked?

The check look like it failed when building the docker image .. The playbook should be fixed with this PR, but I'll look at that issue next :-)

This says "Temporarily" ... Does that mean there's a plan to have a proper fix somewhere? I really don't want to leave anything like this in place ...

I'll continue working on it - the initial thought was to have CentOS6 update Python to 2.7.9 at the beginning of the playbook, but that causes extra issues. What I've tried is in the referenced issue

…k_install/tasks/main.yml

Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
@Willsparker
Copy link
Contributor Author

Converting to Draft as I figure out the Dockerfile issue

@Willsparker Willsparker marked this pull request as draft February 11, 2021 09:31
@Willsparker
Copy link
Contributor Author

Looks like upgrading pip has fixed the Dockerfile issue. I'm not sure why the Ansible_Lint check is failing - it seems to not like ansible/playbooks/adoptopenjdk_variables.yml for some reason.

@sxa
Copy link
Member

sxa commented Feb 12, 2021

ansible-lint failure has been raised #1926 as it's not just affecting this PR, so do not consider that a blocker.

@Willsparker Willsparker marked this pull request as ready for review February 15, 2021 07:44
@karianna karianna requested a review from sxa February 15, 2021 10:37
@sxa
Copy link
Member

sxa commented Feb 16, 2021

NOTE TO REVIEWERS: Discussion currently continuing in #1877

@karianna
Copy link
Contributor

@sxa should we put this in draft?

@Willsparker
Copy link
Contributor Author

Closing as #1970 is better

@Willsparker Willsparker added wontfix and removed bug labels Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants