Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: Install Python2.7 on C6; Use it to install JDKs #1970

Merged
merged 3 commits into from
Feb 24, 2021

Conversation

Willsparker
Copy link
Contributor

Fixes: #1877

IT WORKS! (in VPC at least: https://ci.adoptopenjdk.net/job/VagrantPlaybookCheck/1067/ )

Installs Python 2.7 on CentOS6 and then uses that Python to run the adoptopenjdk_install tasks. See the referenced issue for what other things were tried or suggested. This solution also adds some future proofing somewhat, in that we can just use the Python2.7 whenever we have another unarchive / get_url cert issue because CentOS6 is old.

Checklist
  • commit message has one of the standard prefixes
  • FAQ.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access) : See above
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long does this role to execute? Could be preferable to use the pre-built one I put in place last week instead which would also avoid having to install the extra prereq packages on the machine.

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix YAMLLint please :-)

@Willsparker
Copy link
Contributor Author

How long does this role to execute? Could be preferable to use the pre-built one I put in place last week instead which would also avoid having to install the extra prereq packages on the machine.

About 10 minutes in VPC , not sure on the GHCheck as it doesn't have timestamps. But yeah, okay, I'll try prebuilt :-)

@karianna karianna requested a review from sxa February 24, 2021 09:50
@Willsparker
Copy link
Contributor Author

Well it works! 🎉

@gdams gdams merged commit 7bd63b0 into adoptium:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ansible request for CentOS6 adoptopenjdk_install role
4 participants