Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Cleanup GH Action on windows-2016 (deprecated) #2923

Merged
merged 1 commit into from
May 13, 2022
Merged

feat: Cleanup GH Action on windows-2016 (deprecated) #2923

merged 1 commit into from
May 13, 2022

Conversation

zdtsw
Copy link
Contributor

@zdtsw zdtsw commented May 13, 2022

No description provided.

@github-actions github-actions bot added the windows Issues that affect or relate to the WINDOWS OS label May 13, 2022
karianna
karianna approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zdtsw
Copy link
Contributor Author

zdtsw commented May 13, 2022

@andrew-m-leonard can I get another review on this?

@andrew-m-leonard
Copy link
Contributor

@zdtsw we ought to tidy up the Lint errors?

@zdtsw
Copy link
Contributor Author

zdtsw commented May 13, 2022

@zdtsw we ought to tidy up the Lint errors?

yeah, i have another PR fixing these linter erros, not sure what happened but they just got all checks since last night~~~ 🦀

@karianna karianna merged commit e6e3b03 into adoptium:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-m-leonard andrew-m-leonard andrew-m-leonard approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
windows Issues that affect or relate to the WINDOWS OS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zdtsw @andrew-m-leonard @karianna