fix: GH action checkout bug #2924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
windows
and disable shellcheck - actions/checkout#760 - feat: disable SC on GH action workflows - SC2006:style:2:21: Use $(...) notation instead of legacy backticks `...` - SC2086:info:2:48: Double quote to prevent globbing and word splitting
github-actions
bot
added
windows
zdtsw
changed the title
FILTER_REGEX_EXCLUDE - dont think .github/linters/.jscpd.json works
github-actions
bot
added
windows
This reverts commit 3545f3f.
github-actions
bot
added
windows
github-actions
bot
added
windows
github-actions
bot
added
windows
karianna
requested changes
May 13, 2022
github-actions
bot
added
windows
github-actions
bot
added
windows
github-actions
bot
added
windows
|
think it is finally working: https://github.com/adoptium/temurin-build/runs/6424692834?check_suite_focus=true#step:10:3 |
and disable shellcheck - actions/checkout#760 - feat: disable SC on GH action workflows - SC2006:style:2:21: Use $(...) notation instead of legacy backticks `...` - SC2086:info:2:48: Double quote to prevent globbing and word splitting
FILTER_REGEX_EXCLUDE - dont think .github/linters/.jscpd.json works
This reverts commit 3545f3f.
github-actions
bot
added
windows
github-actions
bot
added
windows
andrew-m-leonard
approved these changes
May 16, 2022
|
could someone help to merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when introduce safe in git
- actions/checkout#760
to fix error seen: https://github.com/adoptium/temurin-build/runs/6419000152?check_suite_focus=true#step:10:39
https://github.com/adoptium/temurin-build/runs/6421732577?check_suite_focus=true
Also, for some reason (might be the nightly maintainance in GH) enabled shellcheck(?), start to see linter error
https://github.com/adoptium/temurin-build/runs/6419326073?check_suite_focus=true