Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] FIX for issue#14869 - Wrong price at backend after update #8

Open
wants to merge 2 commits into
base: 2.3-develop
Choose a base branch
from

Conversation

adrian-martinez-interactiv4
Copy link
Owner

Original Pull Request

magento#14904
A previous commit 9d3be73 (cc @neeta-wagento) changed the default behaviour of
\Magento\Quote\Model\ResourceModel\Quote\Item\Collection::getStoreId() using the store coming from the current session
instead of using the one from quote. The previous commit was made to fix an error while using getItems() without setting a quote.
The implemetation is correctly working in the frontend because the quote storeId is and the session storeId are matchnig, but it breaks the admin implementation because they can be different.

The current fix restore the previous behaviour and adds a check if the quote is not specified.

Fixed Issues (if relevant)

  1. M 2.2.3 price per website - wrong price at backend by a create order after update magento/magento2#14869: Wrong price at backend after update

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…commit 9d3be73 changed the default behaviour of \Magento\Quote\Model\ResourceModel\Quote\Item\Collection::getStoreId() using the store coming from the current session instead of using the one from quote. The previous commit was made to fix an error while using getItems() without setting a quote. The current fix restore the previous behaviour and adds a check if the quote is not specified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants