FIX for issue#14869 - Wrong price at backend after update #14904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous commit 9d3be73 changed the default behaviour of \Magento\Quote\Model\ResourceModel\Quote\Item\Collection::getStoreId() using the store coming from the current session instead of using the one from quote. The previous commit was made to fix an error while using getItems() without setting a quote. The current fix restore the previous behaviour and adds a check if the quote is not specified.
phoenix128
added
bugfix
Release Line: 2.2
Partner: MageSpecialist
partners-contribution
magento-engcom-team
pushed a commit
that referenced
this pull request
May 2, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
May 2, 2018
|
Hi @phoenix128. Thank you for your contribution. |
4 tasks
This was referenced Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous commit 9d3be73 (cc @neeta-wagento) changed the default behaviour of
\Magento\Quote\Model\ResourceModel\Quote\Item\Collection::getStoreId()using the store coming from the current sessioninstead of using the one from quote. The previous commit was made to fix an error while using
getItems()without setting a quote.The implemetation is correctly working in the frontend because the quote storeId is and the session storeId are matchnig, but it breaks the admin implementation because they can be different.
The current fix restore the previous behaviour and adds a check if the quote is not specified.
Fixed Issues (if relevant)
Contribution checklist