Merge pull request #279 from adriengivry/fix/HardwareInfo_widgets_leak

Fixing HardwareInfo panel memory leak
adriengivry · Dec 7, 2023 · c9cceeb · c9cceeb
2 parents a6aa0ea + 95db543
commit c9cceeb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/Sources/Overload/OvUI/include/OvUI/Internal/WidgetContainer.h b/Sources/Overload/OvUI/include/OvUI/Internal/WidgetContainer.h
@@ -19,6 +19,16 @@ namespace OvUI::Internal
 	class WidgetContainer
 	{
 	public:
+		/**
+		* Constructor
+		*/
+		WidgetContainer() = default;
+
+		/**
+		* Destructor. Handle the memory de-allocation of every widgets that are internally managed
+		*/
+		virtual ~WidgetContainer();
+
 		/**
 		* Remove a widget from the container
 		* @param p_widget

diff --git a/Sources/Overload/OvUI/src/OvUI/Internal/WidgetContainer.cpp b/Sources/Overload/OvUI/src/OvUI/Internal/WidgetContainer.cpp
@@ -8,6 +8,11 @@
 
 #include "OvUI/Internal/WidgetContainer.h"
 
+OvUI::Internal::WidgetContainer::~WidgetContainer()
+{
+	RemoveAllWidgets();
+}
+
 void OvUI::Internal::WidgetContainer::RemoveWidget(Widgets::AWidget& p_widget)
 {
 	auto found = std::find_if(m_widgets.begin(), m_widgets.end(), [&p_widget](std::pair<OvUI::Widgets::AWidget*, Internal::EMemoryMode>& p_pair)